Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Refresh handling still assigns optional scopes when scope is omitted and mishandles service-account reconciliation, causing incorrect scope assignments and missing UMA protection access.
3 open issues
What changed in this PR
This PR addresses #55132 by making CIMD metadata refreshes reconcile previously stored capabilities rather than relying solely on partial updates.
Changes:
- Reconciles scopes, grant capabilities, web origins, and metadata-derived attributes.
- Adds authorization-service cleanup and rollback handling for failed creation or refresh.
- Adds regression tests for capability removal, scope and origin updates, and failed-refresh persistence.
| File | Description |
|---|---|
tests/base/src/test/java/org/keycloak/tests/client/policies/ClientIdMetadataDocumentTest.java |
Adds refresh regression tests and supporting helpers. |
services/src/main/java/org/keycloak/protocol/oauth2/cimd/provider/AbstractPersistentClientIdMetadataDocumentProvider.java |
Adds metadata reconciliation, authorization cleanup, and failure rollback. |
Review effort: Balanced
tnorimat
force-pushed
the
ISSUE-55132
branch
from
November 13, 2026 09:30
568e0c3 to
8fcc1b2
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Metadata refreshes can retain a removed backchannel logout URI, while UPDATE policies validate stale logout redirect settings and may reject otherwise valid HTTPS-only updates.
2 open issues
3 resolved since last review
Review effort: Balanced
tnorimat
force-pushed
the
ISSUE-55132
branch
from
November 13, 2026 09:43
8fcc1b2 to
4288324
Compare
tnorimat
force-pushed
the
ISSUE-55132
branch
from
November 16, 2026 00:46
4288324 to
a1c51fa
Compare
…pdate semantics closes keycloak#55132 Signed-off-by: Takashi Norimatsu <takashi.norimatsu.ws@hitachi.com>
tnorimat
force-pushed
the
ISSUE-55132
branch
from
November 16, 2026 02:38
a1c51fa to
530ba81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #55132