Skip to content

Cordova integration tests#216

Draft
eudamniac wants to merge 7 commits intokeycloak:mainfrom
eudamniac:cordova-integration-tests
Draft

Cordova integration tests#216
eudamniac wants to merge 7 commits intokeycloak:mainfrom
eudamniac:cordova-integration-tests

Conversation

@eudamniac
Copy link

@eudamniac eudamniac commented Nov 16, 2025

Attempt to add cordova integration tests - following #27 (comment).

Mocks InAppBrowser plugin by providing a handle for registering event listeners. The urls for the InAppBrowser will be opened in a separate window, leaving the initial page active as it would be with a cordova app.

Next steps could be:

  • Add more tests for cordova adapter
  • Add mock and tests for native cordova adapter
  • Refactor

@jonkoops jonkoops force-pushed the cordova-integration-tests branch from db748fb to da1630f Compare November 18, 2025 16:18
@jonkoops
Copy link
Contributor

Did a quick rebase to include #218 so we can see if the tests will pass.

@eudamniac
Copy link
Author

Did a quick rebase to include #218 so we can see if the tests will pass.

Thanks! Looks like Cordova adapter › allow loaderror on InAppBrowser before finishing login is failing as expected, since there is no fix for #208 included at the moment. I could skip/remove this test for now.

Additionally I see the Firefox - Cross origin tests failing and will have a look at them, I think I missed those those locally some tweaks to the playwright setup.

@eudamniac
Copy link
Author

Fix the tests in 7fbc7fb

@eudamniac
Copy link
Author

@jonkoops just wanted to quickly follow up if I should continue in this direction?

@jonkoops
Copy link
Contributor

Sorry for the late reply, I got bogged down in some other stuff. I think this is going in the right direction, I will try to get a more detailed review in when I can. Currently, I need to fix #209 and #208 and do a release before landing new features. If you have any idea what might be causing those, help is appreciated.

@eudamniac eudamniac force-pushed the cordova-integration-tests branch from 7fbc7fb to 2f34f6b Compare January 4, 2026 15:56
@eudamniac eudamniac force-pushed the cordova-integration-tests branch from 9e5eb34 to f977ef5 Compare February 16, 2026 07:40
@eudamniac
Copy link
Author

eudamniac commented Feb 16, 2026

Sorry for the late reply, I got bogged down in some other stuff. I think this is going in the right direction, I will try to get a more detailed review in when I can. Currently, I need to fix #209 and #208 and do a release before landing new features. If you have any idea what might be causing those, help is appreciated.

No worries, I had my own fair share of other priorities, so apologies for my late response as well. I rebased my changes on latest master and adjusted the tests to latest changes of explicitly navigating in tests, so that they pass locally
image

My plan is to polish the PR this week and put it up for a proper review. Also will have a look at the issues you linked - not too confident that I can be of help there though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants