Skip to content

Set default timeSkew to 60 seconds to avoid forced token refresh (#52)#81

Open
JanekBeck wants to merge 1 commit intokeycloak:mainfrom
JanekBeck:main
Open

Set default timeSkew to 60 seconds to avoid forced token refresh (#52)#81
JanekBeck wants to merge 1 commit intokeycloak:mainfrom
JanekBeck:main

Conversation

@JanekBeck
Copy link

@JanekBeck JanekBeck commented Apr 25, 2025

Closes #52

jonkoops
jonkoops requested changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need some additional tests to verify this behavior works correctly.

@JanekBeck
Copy link
Author

JanekBeck commented Apr 28, 2025

We'll need some additional tests to verify this behavior works correctly.

I will look into it.
Unfortunately I could not get the test setup with Windows 11, WSL 2 and podman to work. The container starts and I can visit the Keycloak server url, but apparently Playwright can't do that.
Hopefully I can find a fix.

@jonkoops
Copy link
Contributor

jonkoops commented Apr 28, 2025

I will look into it. Unfortunately I could not get the test setup with Windows 11, WSL 2 and podman to work.

There should be no need for Podman, to my knowledge, Playwright works natively on Windows.

@jonkoops
Copy link
Contributor

jonkoops commented Jul 8, 2025

Hi @JanekBeck, are you still interested in landing this PR? If so, could you rebase your work?

@JanekBeck
Copy link
Author

JanekBeck commented Jul 15, 2025

Sorry for taking my time. I will update this PR in a few days.

There should be no need for Podman, to my knowledge, Playwright works natively on Windows.

Podman is required on your setup to start a keycloak server

keycloak-js/test/playwright.config.ts

Line 10 in 6041bb4

command: `podman run -p 8080:8080 -p 9000:9000 -e KC_BOOTSTRAP_ADMIN_USERNAME=admin -e KC_BOOTSTRAP_ADMIN_PASSWORD=admin -e KC_HEALTH_ENABLED=true --pull=newer quay.io/keycloak/keycloak:${KEYCLOAK_VERSION} start-dev`,

and the WSL does not allow access to this instance from Windows by default. I will try it with Linux.

@JanekBeck
Set default timeSkew to 60 seconds to avoid forced token refresh (key…
068fd5c 
…cloak#52)

Closes keycloak#52

Signed-off-by: Janek Beck <janek.beck@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonkoops jonkoops jonkoops requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't force token refresh when the token from init() isn't expired

2 participants

@JanekBeck @jonkoops