Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an end-to-end test harness that boots NixOS installs in QEMU/KVM via a Python driver, plumbs OpenTelemetry tracing through Nixie, and runs the harness in GitHub Actions. It also reworks SSH key handling (separate install/deployment keys), persists the post-install IP and machine-id hash to hosts.json, and splits the agent into its own Go package.
Changes:
- New
tests/e2e.pydriver,nix run .#e2erunner, andtest-e2e.yamlGitHub Actions workflow with OTEL collector + trace summary. - OpenTelemetry instrumentation across
cmd/nixie,internal/{api,nixos,pxe}plus a newinternal/telemetrypackage;protocolpackage extracted so the agent stops importinginternal/api. - Replaced password-based SSH with
--install-ssh-key/--deployment-ssh-key; persistipandmachine_id_hash(HMAC-SHA256) back intohosts.json; example flake/installer hardening and placeholder keys.
Reviewed changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e.py | New Python driver: bridge/tap setup, dnsmasq, OVMF QEMU VMs, install/cold-boot verification, trace summary. |
| .github/workflows/test-e2e.yaml | New CI workflow running .#e2e under sudo with magic Nix cache. |
| flake.nix | Splits builds into nixie and nixie-agent, adds apps.e2e runner with Python + qemu/dnsmasq deps. |
| Makefile / README.md | Documents new SSH key flags and test-e2e target. |
| cmd/nixie/{main,flags}.go | Adds telemetry startup, separate install/deployment SSH key flags, PXE error channel. |
| cmd/nixie-agent/{main,client}.go | Switches to new internal/protocol package. |
| internal/api/api.go | Tracing, install host workflow now reads machine ID and saves hosts.json; new SSH key fields. |
| internal/hosts/hosts.go (+test) | Adds IP / machine_id_hash fields, MarshalJSON, SaveHostsConfig, HashMachineID. |
| internal/nixos/{anywhere,installer,machine_id}.go | nixos-anywhere uses SSH key, new machine-id reader, tracing. |
| internal/pxe/pixiecore.go | Wraps pixiecore Server with tracing and event recorder. |
| internal/protocol/protocol.go | New shared InstallRequest type. |
| internal/telemetry/telemetry.go | OTLP gRPC tracer setup keyed off env vars. |
| examples/{flake,installer,configuration}.nix | Refactor + placeholder SSH keys, installer slimming. |
| go.mod / go.sum / gomod2nix.toml | OpenTelemetry deps. |
| .gitignore | Ignore __pycache__/ and /.cache/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+118
to
+123
| case err := <-pxeErrCh: | ||
| if err != nil { | ||
| telemetry.RecordError(runSpan, err) | ||
| log.Fatal("PXE server stopped unexpectedly", "error", err) | ||
| } | ||
| log.Fatal("PXE server stopped unexpectedly") |
khuedoan
force-pushed
the
e2e
branch
2 times, most recently
from
May 30, 2026 04:43
d91a663 to
577535d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.