Update Lulesh-2.0 for Kokkos v3.0 promotion - #2
Open
alanphumphrey wants to merge 2 commits into
Open
Conversation
added 2 commits
July 31, 2019 12:27
Give a default KOKKOS_ARCH arg in Makefiles for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is to update lulesh-2.0 for the Kokkos version 3.0 promotion. There were however, no problems with this mini-app when deprecated code was disabled (KOKKOS_OPTIONS=disable_deprecated_code). Lulesh-2.0 works as is, with support for deprecated code disabled or enabled (the default). Simply made minor updates to the existing Makefiles.
This pull request corresponds to issue #1
There will be a complete removal of deprecated code support after the Kokkos version 3.0 release, hence the intention of this pull request. Current status and timeline for Kokkos code deprecations is at: https://github.com/kokkos/kokkos/wiki/DeprecationPage.
Lulesh-2.0 should work out of the box with Kokkos versions 2.9 (current) and 3.0 (upcoming), but please let me know if you have any problems with the 3.0 release.