Fix bug that makes peda not show register, code, stack information#164
Open
minhbq-99 wants to merge 1 commit intolongld:masterfrom
Open
Fix bug that makes peda not show register, code, stack information#164minhbq-99 wants to merge 1 commit intolongld:masterfrom
minhbq-99 wants to merge 1 commit intolongld:masterfrom
Conversation
peda uses gdb command x/i to get assembly code. In small sized termial,
gdb may return something like this
0x4003f0:\t\njmp QWORD PTR [rip+0x200c22] # 0x601018\n
In context_code function, the above result will become 2 lines, if the
first line reach the else case in this if:
if idx <= pc_idx:
text += line + "\n"
else:
text += " | %s\n" % line.strip()
and it will become
0x4003f0: (without the tab)
When this line is processed by format_disasm_code function
prefix = line.split(":\t")[0]
addr = re.search("(0x[^\s]*)", prefix)
if addr:
addr = to_int(addr.group(1))
to_int is called with "0x4003f0:" argument and it will return None which
will raise an exception in later comparison.
context_code function has msg.bufferize decorator so the exception prevents
msg.flush to be called, the msg.buffering will not be decreased. As a result,
no information can be displayed later since we get the output only when
msg.buffering equals to 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peda uses gdb command x/i to get assembly code. In small sized termial,
gdb may return something like this
In context_code function, the above result will become 2 lines, if the
first line reach the else case in this if:
and it will become
When this line is processed by format_disasm_code function
to_int is called with "0x4003f0:" argument and it will return None which
will raise an exception in later comparison.
context_code function has msg.bufferize decorator so the exception prevents
msg.flush to be called, the msg.buffering will not be decreased. As a result,
no information can be displayed later since we get the output only when
msg.buffering equals to 0.