Drop internal element tags from the ActionForm Style API table - #3817
Merged
Conversation
The tags (<div>, <h2>, <label>, <span>, <input>) were never selectable API. ActionForm emits no documented data-* attributes, and CSS variables cascade from the className, so the element a variable resolves on is irrelevant to the consumer. Five of the twelve rows read <div>, so the parenthetical was already carrying all the meaning. Printing the tags also implied they were stable, contradicting the "class names are internal" caveat directly above the table -- <h2> is exactly as internal as the hashed class name. ObjectTable's table keeps its Element column: there the element is part of the selector, since data-pinned is emitted on both <th> and <td>. Also rename the "Base component" doc sections to "BaseForm" and "BaseTable".
Contributor
size-limit report 📦
|
Contributor
Storybook Preview🧹 Preview removed because this PR was closed. |
nfdiop
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The html tags were never selectable API. ActionForm emits no documented data-* attributes, and CSS variables cascade from the className, so the element a variable resolves on is irrelevant to the consumer.
ObjectTable's table keeps its Element column: there the element is part of the selector, since data-pinned is emitted on both and .
Also rename the "Base component" doc sections to "BaseForm" and "BaseTable".