fix(ahma_mcp): gate a UDS-only restart test behind cfg(unix) - #556
Merged
Conversation
handle_restart_ignores_retired_unix_socket_env_var binds a tokio::net::UnixListener unconditionally, which fails to compile on Windows (E0433: UnixListener is configured out under cfg(unix)) and broke the windows-latest leg of the post-merge matrix. handle_restart itself only ever attempts a UDS connection when cfg!(unix) is true, so the property this test proves - the retired AHMA_UNIX_SOCKET is never contacted - holds trivially and unreachably on non-Unix platforms, with no cross-platform equivalent to gate instead. Per AGENTS.md, #[cfg(unix)] is the correct fix here: the test genuinely needs a Unix-only API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_restart_ignores_retired_unix_socket_env_var binds a
tokio::net::UnixListener unconditionally, which fails to compile on
Windows (E0433: UnixListener is configured out under cfg(unix)) and
broke the windows-latest leg of the post-merge matrix.
handle_restart itself only ever attempts a UDS connection when
cfg!(unix) is true, so the property this test proves - the retired
AHMA_UNIX_SOCKET is never contacted - holds trivially and unreachably
on non-Unix platforms, with no cross-platform equivalent to gate
instead. Per AGENTS.md, #[cfg(unix)] is the correct fix here: the test
genuinely needs a Unix-only API.