Skip to content

synthesize a HTTPS record for pi.hole - #2988

Draft
darkexplosiveqwx wants to merge 9 commits into
pi-hole:developmentfrom
darkexplosiveqwx:feature/https-rr-pihole
Draft

synthesize a HTTPS record for pi.hole#2988
darkexplosiveqwx wants to merge 9 commits into
pi-hole:developmentfrom
darkexplosiveqwx:feature/https-rr-pihole

Conversation

@darkexplosiveqwx

@darkexplosiveqwx darkexplosiveqwx commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

FTL now includes native HTTP/2 and HTTP/3 support, it makes sense to advertise those capabilities via DNS, more specifically the HTTPS RR. Modern browsers are already querying for it in addition to A/AAAA. This allows them to connect directly using QUIC instead of upgrading later.

How does this PR accomplish the above?:

This PR adds an automatically synthesized RFC 9460 HTTPS RR for pi.hole. if any native TLS listener is active.
example:

1 . alpn="h2,h3" port=8086 ipv4hint=127.0.0.1 ipv6hint=::1

alpn is decided based on compile-time support.
The IP hints are localized and match the A/AAAA data.

Limitation I am working on:

This currently doesn't work with CNAMEs targeting pi.hole. It is not as simple as #2585, since dnsmasq's cache differs for host (A/AAAA) and generic Resource Records.

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
HAVE_HTTP* preprocessors directly

Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
@rdwebdesign

Copy link
Copy Markdown
Member

Can you please add some information to the PR template explaining the reasons for this change and adding a few details about the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants