synthesize a HTTPS record for pi.hole - #2988
Draft
darkexplosiveqwx wants to merge 9 commits into
Draft
Conversation
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
HAVE_HTTP* preprocessors directly Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
Member
|
Can you please add some information to the PR template explaining the reasons for this change and adding a few details about the code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
FTL now includes native HTTP/2 and HTTP/3 support, it makes sense to advertise those capabilities via DNS, more specifically the HTTPS RR. Modern browsers are already querying for it in addition to A/AAAA. This allows them to connect directly using QUIC instead of upgrading later.
How does this PR accomplish the above?:
This PR adds an automatically synthesized RFC 9460 HTTPS RR for
pi.hole.if any native TLS listener is active.example:
alpnis decided based on compile-time support.The IP hints are localized and match the A/AAAA data.
Limitation I am working on:
This currently doesn't work with CNAMEs targeting
pi.hole. It is not as simple as #2585, since dnsmasq's cache differs for host (A/AAAA) and generic Resource Records.Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)