Skip to content

pkp/pkp-lib#13789 Use the PDF download URL and batched queries in the sitemap - #6078

Open
bozana wants to merge 2 commits into
pkp:stable-3_5_0from
bozana:13789-3_5_0
Open

bozana wants to merge 2 commits into
pkp:stable-3_5_0from
bozana:13789-3_5_0

Conversation

@bozana

@bozana bozana commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

For pkp/pkp-lib#13789

  • PDF galleys with the download URL, the same as citation_pdf_url, which Google Scholar indexes.
  • issue/current and issue/archive only if there are published issues.
  • Read only the columns the URLs need, in batches of 1000 submissions, instead of loading all submissions as full entities.

Unlike main, articles are still listed through the published issues, and filtered by the submission status.

Includes the pkp-lib and googleScholar submodule updates.

@bozana bozana changed the title 13789 3 5 0 pkp/pkp-lib#13789 Use the PDF download URL and batched queries in the sitemap Nov 13, 2026
$root = $doc->documentElement;
$journalPath = $request->getJournal()->getPath();

$submissions = Repo::submission()->getBestIds($submissionIds);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest not using a variable called $submissions to store these; it suggests they're normal submission objects, when they're actually database results directly returned from a query. (Also other entities)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants