Repository navigation
Conversation
asmecher
requested changes
Nov 16, 2026
| $root = $doc->documentElement; | ||
| $journalPath = $request->getJournal()->getPath(); | ||
|
|
||
| $submissions = Repo::submission()->getBestIds($submissionIds); |
Member
There was a problem hiding this comment.
I suggest not using a variable called $submissions to store these; it suggests they're normal submission objects, when they're actually database results directly returned from a query. (Also other entities)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For pkp/pkp-lib#13789
Unlike main, articles are still listed through the published issues, and filtered by the submission status.
Includes the pkp-lib and googleScholar submodule updates.