Skip to content

Remove references to unsupported architectures #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marti4d merged 1 commit into from
May 8, 2026
Merged

Remove references to unsupported architectures #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,3 @@ fn write_minidump(crash_context: crash_context::CrashContext) {
`i686` | ✅ | ✅ | ❌ | ⭕️ | ❌ | ❌ |
`arm` | ⚠️ | ⚠️ | ⚠️ | ⭕️ | ❌ | ❌ |
`aarch64` | ⚠️ | ⚠️ | ⚠️ | ⭕️ | ✅ | ⭕️ |
`mips` | ⭕️ | ⭕️ | ❌ | ❌ | ❌ | ❌ |
`mips64` | ⭕️ | ⭕️ | ❌ | ❌ | ❌ | ❌ |
`powerpc` | ⭕️ | ⭕️ | ❌ | ❌ | ❌ | ❌ |
`powerpc64` | ⭕️ | ⭕️ | ❌ | ❌ | ❌ | ❌ |
6 changes: 2 additions & 4 deletions src/linux/dumper_cpu_info/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,10 @@ cfg_if::cfg_if! {
if #[cfg(any(
target_arch = "x86_64",
target_arch = "x86",
target_arch = "mips",
target_arch = "mips64"
))]
{
pub mod x86_mips;
pub use x86_mips as imp;
pub mod x86;
pub use x86 as imp;
} else if #[cfg(any(
target_arch = "arm",
target_arch = "aarch64",
Expand Down
6 changes: 1 addition & 5 deletions src/linux/dumper_cpu_info/x86_mips.rs → src/linux/dumper_cpu_info/x86.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,7 @@ pub fn write_cpu_information(sys_info: &mut MDRawSystemInfo) -> Result<()> {
];

// processor_architecture should always be set, do this first
sys_info.processor_architecture = if cfg!(target_arch = "mips") {
MDCPUArchitecture::PROCESSOR_ARCHITECTURE_MIPS
} else if cfg!(target_arch = "mips64") {
MDCPUArchitecture::PROCESSOR_ARCHITECTURE_MIPS64
} else if cfg!(target_arch = "x86") {
sys_info.processor_architecture = if cfg!(target_arch = "x86") {
MDCPUArchitecture::PROCESSOR_ARCHITECTURE_INTEL
} else {
MDCPUArchitecture::PROCESSOR_ARCHITECTURE_AMD64
Expand Down
54 changes: 0 additions & 54 deletions src/linux/thread_info/mips.rs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/linux/thread_info/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ cfg_if::cfg_if! {
} else if #[cfg(target_arch = "aarch64")] {
mod aarch64;
pub type ThreadInfo = aarch64::ThreadInfoAarch64;
} else if #[cfg(target_arch = "mips")] {
mod mips;
pub type ThreadInfo = mips::ThreadInfoMips;
}
}

Expand Down
2 changes: 0 additions & 2 deletions src/minidump_cpu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ cfg_if::cfg_if! {
pub(crate) const FP_REG_COUNT: usize = 32;

pub type RawContextCPU = minidump_common::format::CONTEXT_ARM64_OLD;
} else if #[cfg(target_arch = "mips")] {
compile_error!("flesh me out");
} else {
compile_error!("unsupported target architecture");
}
Expand Down
5 changes: 0 additions & 5 deletions src/minidump_format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ cfg_if::cfg_if! {
pub use format::X86CpuInfo as MDCPUInformation;
} else if #[cfg(any(target_arch = "arm", target_arch = "aarch64"))] {
pub use format::ARMCpuInfo as MDCPUInformation;
} else if #[cfg(target_arch = "mips")] {
pub struct MDCPUInformation {
pub cpuid: [u64; 2],
_padding: [u32; 2],
}
}
}

Expand Down
4 changes: 0 additions & 4 deletions tests/linux_minidump_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ enum Context {
impl Context {
pub fn minidump_writer(&self, pid: Pid) -> MinidumpWriterConfig {
let mut mw = MinidumpWriterConfig::new(pid, pid);
#[cfg(not(target_arch = "mips"))]
if self == &Context::With {
let crash_context = get_crash_context(pid);
mw.set_crash_context(crash_context);
Expand All @@ -44,7 +43,6 @@ impl Context {
}
}

#[cfg(not(target_arch = "mips"))]
fn get_ucontext() -> Result<crash_context::ucontext_t> {
let mut context = std::mem::MaybeUninit::uninit();
unsafe {
Expand All @@ -55,7 +53,6 @@ fn get_ucontext() -> Result<crash_context::ucontext_t> {
}
}

#[cfg(not(target_arch = "mips"))]
fn get_crash_context(tid: Pid) -> CrashContext {
let siginfo: libc::signalfd_siginfo = unsafe { std::mem::zeroed() };
let context = get_ucontext().expect("Failed to get ucontext");
Expand Down Expand Up @@ -86,7 +83,6 @@ macro_rules! contextual_test {
test(Context::Without)
}

#[cfg(not(target_arch = "mips"))]
#[test]
$(#[$attr])?
fn with_context() {
Expand Down
6 changes: 1 addition & 5 deletions tests/ptrace_dumper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,6 @@ fn thread_list_from_parent() {
let process_tid_location = info.regs.uregs[3];
#[cfg(target_arch = "aarch64")]
let process_tid_location = info.regs.regs[3];
#[cfg(target_arch = "mips")]
let process_tid_location = info.mcontext.gregs[1];

let thread_id_data = PtraceDumper::copy_from_process(
*curr_thread,
Expand Down Expand Up @@ -175,7 +173,7 @@ fn thread_list_from_parent() {
// assert_eq!(matching_threads, num_of_threads);
}

#[cfg(not(any(target_arch = "mips", target_os = "android")))]
#[cfg(not(target_os = "android"))]
#[test]
// Ensure that the linux-gate VDSO is included in the mapping list.
fn mappings_include_linux_gate() {
Expand Down Expand Up @@ -376,8 +374,6 @@ fn sanitizes_stack_copies() {
// let heap_addr = thread_info.regs.uregs[3] as usize;
// #[cfg(target_arch = "aarch64")]
// let heap_addr = thread_info.regs.regs[3] as usize;
// #[cfg(target_arch = "mips")]
// let heap_addr = thread_info.mcontext.gregs[1] as usize;

simulated_stack = vec![0u8; 2 * size_of::<usize>()];

Expand Down
Loading