Repository navigation
Read a result line the agent wrapped in backticks - #82
Merged
Merged
Conversation
An agent that copied the marker from its prompt as inline code
(`LORE_NODE_RESULT: {...}`) was read as having said nothing, and a
station with result_required failed a visit that had succeeded.
|
Lore is reviewing this PR — 9f602845-414b-445d-950f-ec0829f0e91c. Submit a review that requests changes to have Lore push a fix for it. Comment |
There was a problem hiding this comment.
Lore review — Approved
Clean, well-tested fix to strip surrounding backticks from line-start LORE_NODE_RESULT: markers.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Posted by floor, visit bbef6620-6cf5-421e-8c61-b42529af16d7.
Merged
gedaiu
added a commit
to re-cinq/lore
that referenced
this pull request
Nov 14, 2026
A person resolved the comment "we need a section about what each agent should do" on a plan's Prototype section and pressed Refine. They expected a written section, one sub-section per station, and got one more sketch. Two things caused it. A Refine of the Prototype section goes to the sketch agent, whose prompt allowed `add-mockup` and nothing else, so a sketch was its only possible answer. And the Refine brief told every agent to "write each of these into the section", which acts on a thread's first message whatever the people in it went on to say, including when one of them did the work. The brief now tells the agent to read each resolved thread to its last message and do what it ends on: nothing where its people did the work themselves, said they will, or agreed nothing is needed, or where the plan already holds what they asked for, and a question where the outcome is unclear. The planning prompt says the same. The sketch agent may add the section a thread on Prototype ends on asking for, as a `custom-` section after Prototype with one sub-heading per item, and asks what the plan does not decide. Its result line is now shown in a fenced block, since two visits on 2026-11-14 copied the inline-code backticks with it (re-cinq/floor#82). Floor migration `0010_refine_acts_on_thread_outcome` writes both prompts to the floor. Which agent a Refine goes to, the pipeline's edges and planning-station are unchanged. A thread the agent leaves alone is still marked used when the pass ends, as before. Not verified here: a real Refine on the floor with the new prompts. That needs the deploy. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent station's outcome is read from a line that starts with
LORE_NODE_RESULT:. An agent that copies the marker from its prompt as inline code prints it with backticks around it, and the parser, anchored at the start of the line, took that for silence. On a station withresult_requiredthe visit then failed with "the agent ended without a LORE_NODE_RESULT or REVIEW_RESULT line", although the agent had finished and said so.Seen on two visits of a
sketchstation on 2026-11-14: both ended with the marker in backticks, both were reported failed, and the work of both was already saved.The marker now matches with backticks before it and after its payload. A marker quoted mid-sentence still decides nothing.
🤖 Generated with Claude Code