Skip to content

Read a result line the agent wrapped in backticks - #82

Merged
gedaiu merged 1 commit into
mainfrom
fix/result-line-in-backticks
Nov 14, 2026
Merged

gedaiu merged 1 commit into
mainfrom
fix/result-line-in-backticks

Conversation

@gedaiu

@gedaiu gedaiu commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

An agent station's outcome is read from a line that starts with LORE_NODE_RESULT:. An agent that copies the marker from its prompt as inline code prints it with backticks around it, and the parser, anchored at the start of the line, took that for silence. On a station with result_required the visit then failed with "the agent ended without a LORE_NODE_RESULT or REVIEW_RESULT line", although the agent had finished and said so.

Seen on two visits of a sketch station on 2026-11-14: both ended with the marker in backticks, both were reported failed, and the work of both was already saved.

The marker now matches with backticks before it and after its payload. A marker quoted mid-sentence still decides nothing.

🤖 Generated with Claude Code

An agent that copied the marker from its prompt as inline code
(`LORE_NODE_RESULT: {...}`) was read as having said nothing, and a
station with result_required failed a visit that had succeeded.
@lore-agent

lore-agent Bot commented Nov 14, 2026

Copy link
Copy Markdown

Lore is reviewing this PR — 9f602845-414b-445d-950f-ec0829f0e91c.

Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.

@lore-agent lore-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lore review — Approved

Clean, well-tested fix to strip surrounding backticks from line-start LORE_NODE_RESULT: markers.

Must fix (0) · Consider (0) · Nits (0)

Reviewed by gemini-4-argon

Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.

Posted by floor, visit bbef6620-6cf5-421e-8c61-b42529af16d7.

@gedaiu
gedaiu merged commit f0a869e into main Nov 14, 2026
16 checks passed
@gedaiu gedaiu mentioned this pull request Nov 14, 2026
@gedaiu
gedaiu deleted the fix/result-line-in-backticks branch November 14, 2026 19:36
gedaiu added a commit to re-cinq/lore that referenced this pull request Nov 14, 2026
A person resolved the comment "we need a section about what each agent
should do" on a plan's Prototype section and pressed Refine. They
expected a written section, one sub-section per station, and got one
more sketch.

Two things caused it. A Refine of the Prototype section goes to the
sketch agent, whose prompt allowed `add-mockup` and nothing else, so a
sketch was its only possible answer. And the Refine brief told every
agent to "write each of these into the section", which acts on a
thread's first message whatever the people in it went on to say,
including when one of them did the work.

The brief now tells the agent to read each resolved thread to its last
message and do what it ends on: nothing where its people did the work
themselves, said they will, or agreed nothing is needed, or where the
plan already holds what they asked for, and a question where the outcome
is unclear. The planning prompt says the same. The sketch agent may add
the section a thread on Prototype ends on asking for, as a `custom-`
section after Prototype with one sub-heading per item, and asks what the
plan does not decide. Its result line is now shown in a fenced block,
since two visits on 2026-11-14 copied the inline-code backticks with it
(re-cinq/floor#82).

Floor migration `0010_refine_acts_on_thread_outcome` writes both prompts
to the floor. Which agent a Refine goes to, the pipeline's edges and
planning-station are unchanged. A thread the agent leaves alone is still
marked used when the pass ends, as before.

Not verified here: a real Refine on the floor with the new prompts. That
needs the deploy.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant