Repository navigation
Vendor the ai-agent-subsystem at v0.21.0: runs on Microsoft Foundry, clones from any https git host - #84
Merged
Conversation
…clones from any https git host
|
Lore is reviewing this PR — e6c12a2b-2c92-40e4-b304-8b8efccf250e. Submit a review that requests changes to have Lore push a fix for it. Comment |
gedaiu
added a commit
to re-cinq/lore
that referenced
this pull request
Nov 17, 2026
… GitHub Enterprise (#4658) The install guide said nothing about Microsoft Foundry, and "GitHub Enterprise" was covered for a self-hosted Server only. The install chart also pinned parts too old for either: Lore images at `be2849d`, a build older than the `GITHUB_HOST` setting (#4642), and floor chart 0.5.3, whose bundled agent subsystem (v0.15.0) can neither clone from a host other than github.com nor call Foundry. The guide now says what a client provides to run Claude Code and Codex agents on Foundry, shows the `agent-secrets` entries that switch it on, and states that Lore's own model calls cannot use Foundry yet. Section 1.6.1 lists the three kinds of GitHub Enterprise and which of them work. The known rough edges gain four items: Lore's own model calls, Foundry and Enterprise Server never having run on a client cluster, Grafana not being in the chart, and no Microsoft Teams integration. The install chart pins the four Lore images at `b4e4484` and floor chart 0.5.4 (re-cinq/floor#84), which bundles the agent subsystem at v0.21.0. Checked: `helm dependency update deploy/install` pulls floor 0.5.4; `helm template lore deploy/install -n lore-floor -f deploy/install/values.azure.example.yaml` renders `ai-agent-controller:v0.21.0`, `ai-agent:v0.21.0`, `floor:0.5.4` and the four `b4e4484` images, and with `GITHUB_HOST` set the host reaches lore-api, lore-ui and lore-stations. Prettier passes on the changed files. Not checked: a real install, a clone from an Enterprise Server, or a Codex run on Foundry. Related: #3909, #3903, #3904, re-cinq/floor#84, re-cinq/ai-agent-subsystem#383 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart bundled the subsystem at v0.15.0 and refused anything newer. Two things a cluster without its own subsystem needs came after that: v0.20.1 lets a run clone from any https git host, where before the credential helper only asked the broker for a repository on github.com, and v0.21.0 lets Claude Code and Codex runs call Microsoft Foundry through entries in
agent-secrets.subsystem.versionis nowv0.21.0and that version joinssupportedVersions; the older ones stay selectable. Upstream's CRDs and RBAC are identical between v0.15.0 and v0.21.0, so bothcrds/copies are untouched. The controller Deployment gains upstream'sapp.kubernetes.io/versionlabel, which the chart derives fromsubsystem.version. The minikube script holds the two digests the v0.21.0 release published, read from the registry for the tag, and the cluster agent moves to@re-cinq/agent-contracts0.21.0.Checked:
scripts/check-chart.shpasses; withsubsystem.enabledthe chart rendersai-agent-controller:v0.21.0andai-agent:v0.21.0, still renders withsubsystem.version=v0.15.0, and refusesv0.99.0. The cluster agent typechecks and its 139 tests pass against the new contracts;eslint .is clean. Not checked: a run on minikube or on a cluster with the new controller.Related: re-cinq/lore#4658, which pins the chart release that follows this.
Generated with Claude Code