Repository navigation
Vendor the ai-agent-subsystem at v0.21.1: gh is authenticated on a GitHub Enterprise Server - #85
Merged
Merged
Conversation
…tHub Enterprise Server
|
Lore is reviewing this PR — a86ffd20-a3fc-4621-a9a3-63c03c1c2480. Submit a review that requests changes to have Lore push a fix for it. Comment |
There was a problem hiding this comment.
Lore review — Approved
Cleanly bumps the vendored ai-agent-subsystem, Helm chart defaults/supported versions, image digests, and @re-cinq/agent-contracts dependency to v0.21.1.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Posted by floor, visit ec1ff557-3d7a-4ca5-be57-a63d2ad6db17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart bundled the subsystem at v0.21.0. v0.21.1 offers the pod's repository token as
GH_ENTERPRISE_TOKENas well asGH_TOKEN.ghreadsGH_TOKENonly for github.com and ghe.com, so on a self-hosted GitHub Enterprise Server an agent cloned and pushed but itsgh pr view,gh pr diffandgh pr commentran unauthenticated.subsystem.versionis nowv0.21.1and that version joinssupportedVersions; the older ones stay selectable. Upstream's CRDs and RBAC are identical between v0.21.0 and v0.21.1, so bothcrds/copies are untouched. The minikube script holds the two digests the v0.21.1 release published, read from the registry for the tag; both carry the image labelv0.21.1. The cluster agent moves to@re-cinq/agent-contracts0.21.1.Checked:
scripts/check-chart.shpasses; withsubsystem.enabledthe chart rendersai-agent-controller:v0.21.1andai-agent:v0.21.1and the version label0.21.1. The cluster agent's 139 tests pass against the new contracts. Not checked: a run on minikube or on a cluster with the new controller, and no run against a real Enterprise Server.Related: re-cinq/ai-agent-subsystem#388, and the re-cinq/lore pull request that pins the chart release that follows this.
🤖 Generated with Claude Code