Skip to content

fix(core): combo type error #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romhml merged 1 commit into from
Jul 15, 2026
Merged

fix(core): combo type error #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ export type PropInputType = 'array' | 'object' | 'stringEnum' | 'primitiveArray'

type StringLiteral<T> = T extends string ? (string extends T ? never : T) : never
type FilterStringLiteral<T> = {
[K in keyof T]: T[K] extends StringLiteral<T[K]> ? K : never;
[K in keyof T]-?: NonNullable<T[K]> extends StringLiteral<NonNullable<T[K]>> ? K : never
}[keyof T]

type ComboItem<T> = keyof FilterStringLiteral<T> | undefined
type ComboItem<T> = FilterStringLiteral<T> | undefined
type Combo<T> = [ComboItem<T>, ComboItem<T>] | [ComboItem<T>]

export type ComponentsDir = {
Expand Down
3 changes: 3 additions & 0 deletions playgrounds/vue/src/components/SupportedProps.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ const _props = defineProps<{
number?: number
boolean?: boolean
primitiveUnion?: string | number | boolean
requiredStringLiteral: 'primary' | 'secondary'
optionalStringLiteral?: 'small' | 'large'

// Arrays
stringArray?: string[]
Expand Down Expand Up @@ -33,6 +35,7 @@ const _props = defineProps<{
}>()

extendCompodiumMeta<typeof _props>({
combo: ['requiredStringLiteral', 'optionalStringLiteral'],
defaultProps: {
string: 'hello',
primitiveUnion: 42,
Expand Down
Loading