pathValue(...): Return 'undefined', instead of a run-time error, when path is not found#9
Open
jayyuen1 wants to merge 1 commit into
Open
Conversation
…ction is called, and a non-existent path is passed in, then return 'undefined' instead of throwing an error. Prior to this commit, a runtime error would be thrown (at least when running within a node.js environment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi s-yadav,
Thanks for writing jsonQ! I like the concept, and think this library is very helpful.
I noticed that, at least when running jsonQ in a node.js environment, I get a run-time error if I call the "pathValue" function when requesting a path that doesn't exist.
I made a small change so that
undefinedis returned instead.For example,
Originally, jsonQ would throw an error in the second line. With the change I am proposing, jsonQ would return
undefinedinstead.What do you think?
Thanks,
jayyuen1