Conversation
gonuke
left a comment
There was a problem hiding this comment.
Thanks @makeclean - here are a few minor comments
…lessly increasing memory usage, implemented remaining functions to make it standalone
|
Now, what I can't figure out is why the G4Polyhedron.hh header isn't being found in CI, when it is present in the version of Geant4 in CI, and is present on my machine, where it builds fine. |
|
Aha, Geant 10.7 is too old to support the most recent changes, I'll put in some support for older versions |
|
Green ticks - 🥳 - just waiting on Mac |
Should we be moving on from older versions? I don't have my finger on that pulse... |
Yeah I would stick to the newest version and maybe upto 2 minor versions previous. |
Description
This PR updates the DagSolid implementation so that it (finally) works as intended for geometries that are imprinted and merged. Through a number of factors, the original author only ever intended for it to work with single isolated dagmc volumes, not entire assemblies as we typically do.
Motivation and Context
This makes it so that DAGMC geometies can be properly, and correctly be transported on using either the MOAB or DoubleDown backend.
Changes
Bug fixes
Behavior
Fixes previously broken implementation.
Changelog file
Changelog will be updated when review completed.