Repository navigation
FIX: Install public headers under include/dagmc/ - #998
Merged
gonuke merged 1 commit intoSep 3, 2026
Merged
Conversation
Namespace the installed headers under include/dagmc/ instead of the top level of the install prefix's include directory, following the include/<project>/ convention of DAGMC's dependencies (e.g. MOAB, Eigen). This avoids collisions and silent wrong-header resolution when DAGMC shares an install prefix with other packages (e.g. DAGMC's installed pyne.h vs. PyNE's include/pyne/pyne.h in a conda environment). The exported CMake package config follows automatically. The imported targets' INSTALL_INTERFACE include directories, DAGMC_INCLUDE_DIRS, and the make_watertight subdirectory headers all derive from INSTALL_INCLUDE_DIR. The previous layout can be restored by configuring with -DINSTALL_INCLUDE_DIR=include. Assisted-by: ClaudeCode:claude-fable-5
4 tasks done
Contributor
Author
|
This is ready for review. |
gonuke
approved these changes
Sep 3, 2026
gonuke
left a comment
Member
There was a problem hiding this comment.
Thanks @matthewfeickert - this seems reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Namespace the installed headers under
include/dagmc/instead of the top level of the install prefix's include directory, following theinclude/<project>/convention of DAGMC's dependencies (e.g. MOAB, Eigen). This avoids collisions and silent wrong-header resolution when DAGMC shares an install prefix with other packages (e.g. DAGMC's installedpyne.hvs. PyNE'sinclude/pyne/pyne.hin a conda environment).The exported CMake package config follows automatically. The imported targets'
INSTALL_INTERFACEinclude directories,DAGMC_INCLUDE_DIRS, and themake_watertightsubdirectory headers all derive fromINSTALL_INCLUDE_DIR. The previous layout can be restored by configuring with-DINSTALL_INCLUDE_DIR=include.Assisted-by: ClaudeCode:claude-fable-5
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
Resolves #997
Changes
What kind of change does this PR introduce? (Bug fix, feature, documentation update...)
A bug fix in the sense that it avoids future user bugs.
Behavior
What is the current behavior? What is the new behavior?
include/.include/dagmc/Other Information
N/A
Changelog file
All pull requests are required to update the CHANGELOG file with the PR. Your update can take different forms including:
Completed in PR.