Skip to content

Drush command to go over CI builds that fail for long time - #201

Open
HelenaEksler wants to merge 22 commits into
masterfrom
195
Open

Drush command to go over CI builds that fail for long time#201
HelenaEksler wants to merge 22 commits into
masterfrom
195

Conversation

@HelenaEksler

@HelenaEksler HelenaEksler commented Aug 4, 2015

Copy link
Copy Markdown
Contributor

@HelenaEksler

HelenaEksler commented Aug 4, 2015

Copy link
Copy Markdown
Contributor Author

@amitaibu Is it better to send mails using message_notify_send_message() and create new message types or using drupal_mail() and create templates in shoov_ci_build module?

amitaibu
amitaibu reviewed Aug 4, 2015
View reviewed changes
Comment thread shoov/modules/custom/shoov_ci_build/drush/shoov_ci_build.drush.inc Outdated

@amitaibu amitaibu Aug 4, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove arguments, keep range (50)

amitaibu
amitaibu reviewed Aug 6, 2015
View reviewed changes
Comment thread shoov/modules/custom/shoov_ci_build/drush/shoov_ci_build.drush.inc Outdated

@amitaibu amitaibu Aug 6, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move each logic to own function. If one of those functions returns TRUE you know it means a mail should be sent.

@HelenaEksler HelenaEksler changed the title WIP: Drush command to go over CI builds that fail for long time Drush command to go over CI builds that fail for long time Aug 13, 2015
nedSaf
nedSaf reviewed Aug 13, 2015
View reviewed changes
Comment thread shoov/modules/custom/shoov_ci_build/drush/shoov_ci_build.drush.inc Outdated

@nedSaf nedSaf Aug 13, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use here strtotime, e.g: strtotime("-3 days") ? for all the timestamps ?

@HelenaEksler HelenaEksler assigned amitaibu and unassigned nedSaf Aug 16, 2015
@HelenaEksler

HelenaEksler commented Aug 16, 2015

Copy link
Copy Markdown
Contributor Author

@amitaibu PR is ready for review.

@amitaibu

amitaibu commented Sep 10, 2015

Copy link
Copy Markdown
Member

Can you please confirm script on the DEV dump

@HelenaEksler

HelenaEksler commented Sep 10, 2015

Copy link
Copy Markdown
Contributor Author

selection_088
Working with the dump, but there are no long time failing builds. Is it correct?

@amitaibu

amitaibu commented Sep 10, 2015

Copy link
Copy Markdown
Member

I doubt it

@HelenaEksler

HelenaEksler commented Sep 10, 2015

Copy link
Copy Markdown
Contributor Author

OK, I'll try to check manually.

@HelenaEksler

HelenaEksler commented Sep 10, 2015

Copy link
Copy Markdown
Contributor Author

I've fixed the script.
Builds are processed. Mails are sent.
selection_089
selection_090
selection_091

@amitaibu

amitaibu commented Sep 10, 2015

Copy link
Copy Markdown
Member

Seems the mail is missing a link to the shoov's CI build

@HelenaEksler

HelenaEksler commented Sep 10, 2015

Copy link
Copy Markdown
Contributor Author

It should lead to the app, right?

@amitaibu

amitaibu commented Sep 10, 2015

Copy link
Copy Markdown
Member

yeah, no access to the server anyway

@HelenaEksler

HelenaEksler commented Sep 10, 2015

Copy link
Copy Markdown
Contributor Author

selection_092

This is the message.

@amitaibu

amitaibu commented Sep 10, 2015

Copy link
Copy Markdown
Member

Can you make the message a little more formal: line breaks, a bit more info, etc'

@HelenaEksler

HelenaEksler commented Sep 16, 2015

Copy link
Copy Markdown
Contributor Author

@amitaibu
Here are messages user will get:
selection_102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@amitaibu amitaibu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HelenaEksler @amitaibu @nedSaf