Skip to content

refactor(transform): keep rebuilder.splice with the rebuilder - #313

Merged
siyul-park merged 2 commits into
mainfrom
refactor/rebuilder-splice
Nov 10, 2026
Merged

siyul-park merged 2 commits into
mainfrom
refactor/rebuilder-splice

Conversation

@siyul-park

Copy link
Copy Markdown
Owner

Summary

rebuilder.splice, added with InlinePass in #307, was declared in inline.go. Lighthouse's design/owner-file flagged it: the repository keeps a type's methods in that type's file. This PR moves it verbatim to rebuild.go, ahead of the methods it calls (declaration-groups). There is no code change.

Evidence

go test ./internal/transform ./internal/jit/..., make check (pre-commit) and git diff --check pass.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6aa815aa-7571-40de-8a43-2b8bfe0f9ac7
Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

splice is a rebuilder method and lived in inline.go, its only caller's
file. A type's methods stay in the type's file; move it to rebuild.go
unchanged, ahead of the methods it calls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@siyul-park
siyul-park force-pushed the refactor/rebuilder-splice branch from 424a1a9 to 8c71cd4 Compare November 10, 2026 03:16
@siyul-park
siyul-park merged commit de2af9c into main Nov 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant