Repository navigation
refactor(transform): keep rebuilder.splice with the rebuilder - #313
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
splice is a rebuilder method and lived in inline.go, its only caller's file. A type's methods stay in the type's file; move it to rebuild.go unchanged, ahead of the methods it calls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
siyul-park
force-pushed
the
refactor/rebuilder-splice
branch
from
November 10, 2026 03:16
424a1a9 to
8c71cd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rebuilder.splice, added withInlinePassin #307, was declared ininline.go. Lighthouse'sdesign/owner-fileflagged it: the repository keeps a type's methods in that type's file. This PR moves it verbatim torebuild.go, ahead of the methods it calls (declaration-groups). There is no code change.Evidence
go test ./internal/transform ./internal/jit/...,make check(pre-commit) andgit diff --checkpass.🤖 Generated with Claude Code