Repository navigation
refactor(transform): report unsupported translation by sentinel - #351
Merged
Merged
Conversation
Translate signalled "unsupported" by returning nil, nil, nil from seven paths, and its three callers each tested f == nil. It now returns transform.ErrUnsupported wrapped with the stage that declined: no code, code before the first block, analysis, an unreached entry, or an operation build rejects. compile maps it to compile.ErrUnsupported at its boundary; SSAPass skips the function; InlinePass skips the callee. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transform.Translatesignalled "unsupported" by returningnil, nil, nilfrom seven paths, and its three callers each testedf == nil— a weak contract next to coding-patterns' rule that semantic failures useErrXxxsentinels translated at their owning boundary.transform.ErrUnsupported, wrapped with the stage that declined: no code, code before the first block, analysis, an unreached entry, or an operationbuildrejects.compile.buildmaps it tocompile.ErrUnsupportedat its boundary (interp'spolicy.drainclassification unchanged);SSAPassskips the function;InlinePassskips the callee.TestTranslate's ten unsupported cases assertErrorIs(err, transform.ErrUnsupported)instead ofNoError+Nil.Last of the pipeline structural cleanups (after #346–#350).
Evidence
Test plan
go test ./internal/transform ./internal/jit/... ./optimize ./interpmake checkgit diff --check🤖 Generated with Claude Code