Skip to content

removes incorrect duplicate parsing of TimeDateStamp #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhhcs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

removes incorrect duplicate parsing of TimeDateStamp #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c963464
removes incorrect duplicate parsing of TimeDateStamp
huettenhain Nov 24, 2025
039f467
removes remaining references to Reserved field
huettenhain Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions minidump/header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ def __init__(self):
self.NumberOfStreams:int = None
self.StreamDirectoryRva:int = None
self.CheckSum:int = 0
self.Reserved:int = 0
self.TimeDateStamp:int = 0
self.Flags:MINIDUMP_TYPE = None

Expand All @@ -22,7 +21,6 @@ def to_bytes(self):
t += self.NumberOfStreams.to_bytes(4, byteorder = 'little', signed = False)
t += self.StreamDirectoryRva.to_bytes(4, byteorder = 'little', signed = False)
t += self.CheckSum.to_bytes(4, byteorder = 'little', signed = False)
t += self.Reserved.to_bytes(4, byteorder = 'little', signed = False)
t += self.TimeDateStamp.to_bytes(4, byteorder = 'little', signed = False)
t += self.Flags.value.to_bytes(4, byteorder = 'little', signed = False)

Expand All @@ -39,7 +37,6 @@ def parse(buff):
mh.NumberOfStreams = int.from_bytes(buff.read(4), byteorder = 'little', signed = False)
mh.StreamDirectoryRva = int.from_bytes(buff.read(4), byteorder = 'little', signed = False)
mh.CheckSum = int.from_bytes(buff.read(4), byteorder = 'little', signed = False)
mh.Reserved = int.from_bytes(buff.read(4), byteorder = 'little', signed = False)
mh.TimeDateStamp = int.from_bytes(buff.read(4), byteorder = 'little', signed = False)
try:
mh.Flags = MINIDUMP_TYPE(int.from_bytes(buff.read(4), byteorder = 'little', signed = False))
Expand All @@ -62,7 +59,6 @@ def __str__(self):
t+= 'NumberOfStreams: %s\n' % self.NumberOfStreams
t+= 'StreamDirectoryRva: %s\n' % self.StreamDirectoryRva
t+= 'CheckSum: %s\n' % self.CheckSum
t+= 'Reserved: %s\n' % self.Reserved
t+= 'TimeDateStamp: %s\n' % self.TimeDateStamp
t+= 'Flags: %s\n' % self.Flags
return t
1 change: 0 additions & 1 deletion minidump/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ def prepare_header(self):
self.header.NumberOfStreams = len(self.streams) +1 # +1 is fot he memory info stream
self.header.StreamDirectoryRva = self.directory_rva
#self.header.CheckSum = None
#self.header.Reserved = None
#self.header.TimeDateStamp = None
self.header.Flags = MINIDUMP_TYPE.MiniDumpWithFullMemory
self.header_buffer.write(self.header.to_bytes())
Expand Down