Free the business code from the token argument. - #7
Conversation
|
it will probably breaks moffics.py too |
|
Seems good, but just to be safe, maybe add a before_request method that resets session token, as it's the same session object in every http query something like : (i dont know how to add suggested patch on pr… :/ ) |
|
|
||
| Raise AuthenticationException in case of error | ||
| """ | ||
| TOKEN: str |
There was a problem hiding this comment.
moffi_sdk/auth.py:37:8: C0103: Attribute name "TOKEN" doesn't conform to snake_case naming style (invalid-name)
|
The best way would be to authenticate and create the session on server start and actually use the same token right? |
probably not, for 2 reasons
I suggest to re-signing on every request |
|
The |
Simplify the code in order to introduce new features.