Support PNPM - #4
Open
vsumner wants to merge 37 commits into
Open
Conversation
- Fall back to pnpmPackage.fetchDeps when pkgs.fetchPnpmDeps is missing (World's nixpkgs exposes fetchDeps on the pnpm package, not top-level) - Allow engines.pnpm range when packageManager provides exact version (admin-web has "pnpm": "^10" in engines + "pnpm@10.17.0" in packageManager) - Set engine-strict=false in prefetch and build (nixpkgs node may lag behind engines.node constraint)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the Node workflow in onix (pnpm import → generate → build → hydrate), and includes the core safeguards needed for real monorepos.
What This Adds
pnpm-lock.yaml(workspace-aware).nodeModules.node_modulesfrom Nix store artifacts.nix-buildwhen identity is unchanged and targetnode_modulesexists.link:workspace validation ingenerate:onix import --allow-pnpm-patch-driftallows only same-major exact patch drift.pnpm-lock.yaml/pnpm-lock.yml).README.mdandAGENTS.md.Why
Validation
test/generate_node_test.rbtest/hydrate_node_test.rbtest/build_node_test.rbtest/pnpm_importer_test.rbrake test).onix checkpasses.vercel/turborepovercel/swrnode_modules unchanged) with sub-second timings.Notes