Allow blank bin generation - #163
Draft
noobydp wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
CI exposed one existing half-grid test that still assumed I added a follow-up commit that keeps the test's validity checks but compares the standard and half-grid generated outer envelopes instead. That preserves the half-grid coverage without depending on solid-shell volume behavior. Additional local checks run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blank bins are useful when a drawer layout needs an empty container, spacer, or catch-all bin alongside traced tool bins. Previously, empty bins could be created in the UI but could not be generated, and the generator behavior did not let the cutout depth define the usable interior cavity. This makes blank bins behave like intentional printable containers instead of requiring a placeholder tool shape.
Summary
Testing
python -m pytest backend/tests/test_blank_bin_generation.pyCode and PR drafted with Codex