test: clean up string formatting TODO in test_parent_err - #496
Merged
Conversation
dfellis
approved these changes
Jul 26, 2026
isaacbrodsky
approved these changes
Jul 29, 2026
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
Contributor
Author
|
@isaacbrodsky I've applied your suggestion to remove the 0x prefix! Let me know if you need to re-approve the CI workflows for this new commit, or if it is fully good to merge. |
Contributor
Author
|
@isaacbrodsky It looks like the CI tests failed after applying the suggestion! I dug into it, and it turns out the underlying library's exception message actually does include the |
dfellis
approved these changes
Aug 3, 2026
isaacbrodsky
approved these changes
Aug 3, 2026
Contributor
Author
|
Grateful for the merge—thank you! I’m here if any additional changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a quick cleanup PR to resolve a lingering
todocomment I noticed while looking through the test suite.In
test_parent_errinsidetests/test_lib/test_cells_and_edges.py, there was a comment to revisit the "weird formatting stuff" used to generate the hex error message. I replaced the clunkyhex(h3.str_to_int(h))conversion with a standard, readable Python f-string:f'Invalid parent resolution -1 for cell 0x{h}.'This makes the test much more idiomatic and removes the TODO without changing any of the underlying test logic.
Maintainers
cc: @dfellis @ajfriend @isaacbrodsky - Just a small housekeeping fix for whenever you have the time to review!