refactor: improve test suite maintainability and add security audit#335
Open
Kozak809 wants to merge 1 commit into
Open
refactor: improve test suite maintainability and add security audit#335Kozak809 wants to merge 1 commit into
Kozak809 wants to merge 1 commit into
Conversation
ulsklyc
requested changes
Jun 11, 2026
Owner
There was a problem hiding this comment.
Code Review
Verdict: Changes requested — one blocking bug + two smaller issues.
🚫 Blocking
package.json:63 — test:settings-navigation missing from aggregated test run
The PR removes && npm run test:settings-navigation && from the test chain (between test:kitchen-tabs and test:mobile-scroll-layout). This is not an intentional removal but a rebase artifact — the branch was cut from an outdated main. After merging, this suite would never run in CI again.
Fix: Rebase the branch onto the current main and restore the missing call.
⚠️ Should fix
package.json:65—npm audit --productionis deprecated on npm v7+ (this repo runs npm 11.16.0). The modern flag isnpm audit --omit=dev. Otherwise it starts with a deprecation warning.package.json(last line) — no trailing newline at end of file (\ No newline at end of filein the diff). Violates POSIX standard and causes unnecessary diffs on the next change.
💡 Nice to have
- No
CHANGELOGentry under## [Unreleased]for this tooling change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm testscript inpackage.jsonto leverage existing, granular test scripts. This enhances maintainability, makes individual test suites easier to debug, and improves the overall robustness of the CI/CD pipeline.auditscript topackage.json(npm run audit) to facilitate regular security auditing of production dependencies, which is a critical practice for self-hosted applications.Rationale:
The previous
npm testscript was a complex, fragile, and difficult-to-maintain chain of commands. By modularizing it, we improve developer experience and reduce the likelihood of integration errors. The addition of an audit script proactively addresses security concerns.Technical Impact Analysis: