Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

API preview: https://pr-17567-api.vm6.ai

⚡ Lighthouse — Web

Tested URL: https://pr-17567-www.vm6.ai/ · Full report

Code Review: PR #17567

Summary

Reviewed the Claude Fable 5 removal across active model catalogs, VM0 routing, provider model lists, web model-page data, guest-agent Claude args, and migration 0459. The approach matches the existing removed-model pattern: remove the model from active catalogs and migrate active stored selections, while preserving historical run/pricing data.

Key Findings

Critical Issues (P0)

• None found.

High Priority (P1)

• None found.

Testing Review

Coverage

• fix: remove Fable from supported run models/provider lists/model page/provider UI/guest-agent effort handling -> covered by model-providers.test.ts, data.test.ts, vm0-provider.test.ts, and build_claude_args_omits_effort.
• fix: migrate active Fable selections and org model policies to Opus 4.8 -> covered by 0459_remove_claude_fable_5.test.ts.
• fix: ignore unsupported stored user/default model selections at default resolution -> covered indirectly by policy/model-selection tests and catalog schema tests.

Convention Compliance

• No internal vi.mock() usage.
• No direct fetch mocking.
• No fake timers or artificial sleeps.
• No DB mocking; migration tests use real DB state.
• No lint/type suppressions or any usage introduced.

Testing Verdict: Adequate

Bad Smell Analysis

• Mock violations: 0
• Test coverage issues: 0
• Defensive programming: 0
• Dynamic imports: 0
• Type safety issues: 0
• Lint/type suppressions: 0
• Timer/delay issues: 0

Verification Run During Review

• pnpm -F @vm0/api-contracts exec vitest run src/contracts/__tests__/model-providers.test.ts
• pnpm -F @vm0/db exec vitest run src/__tests__/migrations/0459_remove_claude_fable_5.test.ts
• pnpm -F api exec vitest run src/signals/routes/__tests__/zero-model-policies.test.ts
• pnpm -F web exec vitest run 'app/[locale]/models/__tests__/data.test.ts' src/__tests__/vm0-provider.test.ts
• cargo test --manifest-path crates/Cargo.toml -p guest-agent build_claude_args_omits_effort
• pnpm -F @vm0/db test:migration-consistency
• git diff --check

Recommendations

• No blocking changes requested.

Verdict

LGTM

Full review details: codereviews/20260613/pr-17567-commit-list.md
Testing standards: docs/testing.md

Code Review: PR #17567

Summary

Reviewed the Claude Fable 5 removal across active model catalogs, VM0 routing, provider model lists, web model-page data, guest-agent Claude args, default model resolution, and migration 0459. The approach matches the existing removed-model pattern: remove the model from active catalogs and migrate active stored selections, while preserving historical run/pricing data.

Key Findings

Critical Issues (P0)

• None found.

High Priority (P1)

• None found.

Testing Review

Coverage

• fix: remove Fable from supported run models/provider lists/model page/provider UI/guest-agent effort handling -> covered by model-providers.test.ts, data.test.ts, vm0-provider.test.ts, and build_claude_args_omits_effort.
• fix: migrate active Fable selections and org model policies to Opus 4.8 -> covered by 0459_remove_claude_fable_5.test.ts, including idempotency, existing-replacement merge, provider aliases, and historical zero_runs/usage_pricing preservation.
• fix: ignore unsupported stored user/default model selections at default resolution -> covered by catalog schema/provider tests and the service query now filtering to SUPPORTED_RUN_MODELS.

Convention Compliance

• No internal vi.mock() usage.
• No direct fetch mocking.
• No fake timers or artificial sleeps.
• No DB mocking; migration tests use real DB state.
• No lint/type suppressions or new any usage introduced.

Testing Verdict: Adequate

Bad Smell Analysis

• Mock violations: 0
• Test coverage issues: 0
• Defensive programming: 0
• Dynamic imports: 0
• Type safety issues: 0
• Lint/type suppressions: 0
• Timer/delay issues: 0

Recommendations

• No blocking changes requested.

Verdict

LGTM

Full review details: codereviews/20260613/pr-17567-commit-list.md
Testing standards: docs/testing.md