🏗️ arch(web): place search tools in spark-tool-web and spark-web as the app - #482
Open
zrr1999 wants to merge 1 commit into
Open
🏗️ arch(web): place search tools in spark-tool-web and spark-web as the app#482zrr1999 wants to merge 1 commit into
zrr1999 wants to merge 1 commit into
Conversation
…he app Search/fetch is a stateless tool family, so it now lives at packages/spark-tool-web. spark web is a Spark-owned process, so the DSH profile boot and onboarding client move into apps/spark-web with a spark-web companion. The dispatcher spawns that companion like hub/tui. Package budget stays closed at 44.
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
动机
spark-tool-<family>是无状态工具族的库存命名;web_search/fetch_content不拥有 Spark 进程。spark web才是进程:启动 DSH web profile、写入管理插件、并作为 dispatcher 平面。把 DSH 客户端留在packages/会让它看起来像 capability,而真正进程仍然在spark-cli里 in-process 启动。解决方案
@zendev-lab/spark-web重命名为@zendev-lab/spark-tool-web(packages/spark-tool-web)。@zendev-lab/spark-web成为apps/spark-web应用:吸收原spark-web-dsh客户端插件与 CLI 的 DSH boot,提供spark-webcompanion。spark web通过 dispatcher spawn companion(与spark hub/spark tui相同),不再在 CLI 进程内 import boot 路径。说明
responseId前缀仍为spark-web:;存储路径仍为.spark/web/content.json。@zendev-lab/spark-web/extension会 rewrite 到@zendev-lab/spark-tool-web/extension。spark-web-dsh,已有 profile 不会 double-insert;profile 仍通过@zendev-lab/spark-web-dsh解析客户端插件。后续工作
spark web仍启动 DSH profile。dsh-toolsguard/pre-execute、dsh-scope、nativespark-files插件。