Place the half-grid remainder cell at the end - #2
Merged
Conversation
For a 3.5 x 2.5 grid the trailing 21mm cell showed up at the top of the STL while the bin editor drew it along the bottom, so tools were placed against a row of base that the printed bin did not have there. The editor draws its grid from the top-left corner, which puts the partial cell in the right column and the bottom row, and that is now the canonical placement. Manifold +y is the editor's top edge, so the base cell layout on the y axis is built partial-cell-first. Cell geometry moved to _cell_bounds/_cell_center, which read the real cell spans: disabled-cell cutters, stability plates and the label-to-cell mapping used a fixed 42mm box around a centre that was off by half a cell whenever the axis was fractional. Magnet placement now carries the cell index with each full cell instead of matching centres by value. The 2D canvas rounded its cell counts down, so for fractional grids the partial row and column never got a disabled overlay and the row indexing slipped by a fraction; counts round up and the last cell is clipped to the bin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
manifold3d's booleans can leave two vertices that should be identical ~1e-4mm apart instead of exactly coincident. trimesh's default merge_vertices() tolerance is tighter than that gap, so the later nondegenerate_faces() pass drops the resulting sliver triangle without first welding its vertices into their neighbors -- opening a small boundary hole that slicers report as non-manifold geometry. Reproduced on a real customer export (a split part failed Orca's manifold check) and, deterministically without any tool data, on a plain stacking-lip bin at grid_y=6 (252mm) -- below that size the same config exports clean, so this is a precision issue, not a modeling bug. merge_vertices(digits_vertex=3) welds anything within 1um, comfortably below FDM resolution, before the degenerate-face cleanup runs.
The canvas fix had no frontend test: a fractional grid built fewer marker columns than the mask has and indexed it at fractional offsets, so disabled cells went unmarked, and the trailing cell hung over the bin edge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1Richter
added a commit
that referenced
this pull request
Aug 4, 2026
Brings together every open self-host PR (#2-#16) on top of upstream 0.8.0+7: #2 fix/half-grid-cell-placement #10 feat/custom-bin-size-mm #3 feat/split-multi-part #11 feat/cutout-line #4 feat/preview-bed-size-grid #12 feat/dashboard-hide-project-bins #5 fix/split-parts-3mf-export #13 feat/persist-tracer-selection #6 feat/always-export-3mf #14 feat/tool-quantity-duplicates #7 ci/run-frontend-tests #15 feat/unload-idle-models #8 feat/bin-editor-cutout-depth-cap #16 fix/clamp-autosize-grid #9 feat/bin-editor-cutout-editing Verified: 401 backend tests, 189 frontend tests, ruff and tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR opened for review. Branch:
fix/half-grid-cell-placement.