Skip to content

added BSSIDgenerator - #1

Open
takyon12 wants to merge 3 commits into
masterfrom
i17
Open

added BSSIDgenerator#1
takyon12 wants to merge 3 commits into
masterfrom
i17

Conversation

@takyon12

Copy link
Copy Markdown

No description provided.

@Horkyze

Horkyze commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

@Horkyze
Horkyze self-requested a review November 6, 2017 20:54

@Horkyze Horkyze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potrebujeme vlastne 2 rozne sposoby na generovanie BSSID? - preberieme na stretnuti asi
IMHO takto je to zbytocne complicated (+ by sme sa vyhli aj code duplicity ktora tam je - funkcia: static String byteToHex(final byte[] hash))

ked sa to bude pouzivat na inych miestach kodu, tak si to celkom dobre viem predstavit ako static class s takouto metodou:

MacAddress getUniqBssid(MacAddress m)

, ktora vrati vygenerovane BSSID na zaklade mac address.

MacAddress moze byt uz existujuca class vo floodlighte alebo mozme aj vytvorit alebo jednoducho iba pole bytes.

//System.out.println("Pearson fingerprint: " + byteToHex(hash));

StringBuilder builder = new StringBuilder(byteToHex(hash));
builder.setCharAt(1, 'e');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mozno by bolo dobre dat kludne aj prve 2 bytes na 'e' - aby sa potom lepsie citali packety vo wiresharku :)

builder.setCharAt(0, 'e');
builder.setCharAt(1, 'e');
builder.setCharAt(2, 'e');
builder.setCharAt(3, 'e');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to iste aj pre BSSIDGen_sha1.java

@takyon12

takyon12 commented Nov 6, 2017

Copy link
Copy Markdown
Author

nepotrebujeme dve, staci nam vybrat jedno z tychto dvoch, druhe som dorobila kvoli koliziam (ked sa generuje SHA1 fingerprint a berie sa z toho len 6 bytov + este sa nastavuje aby to bolo z private range, tak sa ti teoreticky zvysuje riziko kolizii ..... prebereme na stretnuti)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants