[19.0][MIG] dms_field: Migration to 19.0#486
Open
mmircoli-nexapp wants to merge 78 commits into
Open
Conversation
... so to speak. @Tecnativa TT29847
Co-authored-by: luismalta <luis.malta@kmee.com.br>
Approved Enric Tobella OCA#169
Currently translated at 100.0% (75 of 75 strings) Translation: dms-15.0/dms-15.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_field/it/
Currently translated at 100.0% (75 of 75 strings) Translation: dms-15.0/dms-15.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_field/it/
The root directory can't be opened using the contextual action menu (`open`)
Impacted versions:
12.0 and above
Steps to reproduce:
Go to "DMS directories" in the partner form view
Create a new root directory
Right-click and choose `Open`
Current behavior:
Odoo raises an error `TypeError: record is null`
Expected behavior:
Open the directory like if we click on the `Open` button in the right section (Document preview)
- Create dms.field.template to set model, groups and directory structure. - Remove the wizard to create a directory from a record. - Directory structure is created when record is created (partner for example). - Change the information on the right side. - Have directory/file tree open when loading. TT46804 TT46804
…cut several files and paste them into another directory) TT47482
…n as default state Before this change, when lauching the reload, the child directories of the reloaded one are opened too. By doing at this step and not setting the default state, the reloads are done just for the implied nodes. Furthermore, the code is improved to just reload the directories that have being changed.
Currently translated at 100.0% (75 of 75 strings) Translation: dms-15.0/dms-15.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_field/es/
With hr_dms_field The steps to reproduce the problem are: 1. Open Employee 2. Go to Documents Page 3. Drop a file on a directory 4. Go to another Employee 5. Try to drop a file The file can not be dropped.
In the migration, the view type is changed from dms_tree to dms_list. That's because in this point https://github.com/odoo/odoo/blob/16.0/addons/web/static/src/views/fields/field.js#L282 the 'tree' string is replaced by 'list' what is causing problems trying to set the view type as it was before.
A parent directory can be set in templates, if set, the directory that is created linked to a record will be a "child" of that directory. TT48650
…ors when creating directories from a template. Example of use case: - Create a partner. - Create a template linked to partners. - Create a directory through the template. - An access group linked to the partner is created. - Delete the partner directory. - Creates a new directory through the template. - No error will occur and the previous access group will be re-used.
…ring Now the process will be as follows: - The auto-generated access group will be created. - The user will be defined in explicit_user_ids of the group created in the previous step. In the directory created (from the corresponding record) the auto-generated group (for the user to have access) + the access groups that the template had will be used.
…race condition with hr_holidays accrual plan
Use case: - Modify the user Marc Demo and define some permissions in Employees - Go to the employee Abigail Peterson and create her folder - Modify the Access group > Everyone for Employee DMS and remove the corresponding group to leave only Mitchell Admin defined as an explicit user - Log in with Marc Demo and try to modify some data for the employee Abigail Peterson (define a tag, for example). TT60793
Currently translated at 91.9% (57 of 62 strings) Translation: dms-18.0/dms-18.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-18-0/dms-18-0-dms_field/es/
Added domain related to storage_id which allows to create directories for same records with required template across multiple storages.
If, for example, l10n_es_aeat_mod190 is installed and the tests are run, the following log is generated:
WARNING devel py.warnings: /opt/odoo/auto/addons/dms_field/models/ir_ui_view.py:21:
FutureWarning: The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead
File "/opt/odoo/auto/addons/dms_field/models/ir_ui_view.py", line 21, in _postprocess_tag_dms_list
if parent_name := parent and parent.get("name"):
Currently translated at 95.0% (58 of 61 strings) Translation: dms-18.0/dms-18.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-18-0/dms-18-0-dms_field/ar/
Currently translated at 100.0% (61 of 61 strings) Translation: dms-18.0/dms-18.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-18-0/dms-18-0-dms_field/sl/
7 tasks
Member
|
6 PRs created automatically at once? None of them pass the tests? I'm sorry, but I'm not going to waste my time reviewing something that not even the person who created it (perhaps automatically by AI) has done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of dms_field to 19.0
Changes: