fix: placeholder parsing in sound expressions - #565
Merged
Conversation
Component.unstyled() wrapped every name/lore line in an empty parent
component (color(null), italic false) via append(), so the CUSTOM_NAME
data component ended up as {"text":"","extra":[{"text":"Name"}]}
instead of a flat {"text":"Name"}. Anvil renames (and any other
FastItemStack.displayName/lore write) go through this path, so every
renamed item's custom_name diverged from vanilla's format, breaking
resource packs that key item models off custom_name.
Use decorationIfAbsent(ITALIC, FALSE) directly on the component instead
of wrapping it, which only resets the implicit italic on custom names
without introducing a synthetic parent/child structure.
…placeholder context AbstractPlayableSound's config deserializer always evaluated pitch/ volume expressions against PlaceholderContext.EMPTY, so any expression referencing a placeholder (e.g. %libreforge_points_x%) silently resolved with that placeholder missing, producing a wrong or constant result regardless of the actual value. Add create(Config, PlaceholderContext) overloads that thread a real context through readNumber/readRangePart; the existing no-context create(Config) keeps using PlaceholderContext.EMPTY for callers that have none.
CallumJohnson
requested changes
Aug 5, 2026
This leaked in from the anvil PR and is unrelated to sound placeholder expressions; reviewer flagged it for removal.
CallumJohnson
approved these changes
Aug 7, 2026
…eholder-expressions # Conflicts: # eco-api/src/main/java/com/willfp/eco/core/sound/AbstractPlayableSound.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.