fix: CMI and Vault registration issue - #576
Closed
Exanthiax wants to merge 1 commit into
Closed
Conversation
The Vault economy integration was resolved once, synchronously, during plugin onEnable. If the actual economy provider (e.g. CMI) registers with Vault's ServicesManager after that point - which can happen since plugin enable order between two plugins that both merely soft-depend on Vault isn't guaranteed - the lookup returned null and no economy integration was ever registered. EconomyManager then failed silently on every balance operation for the rest of the server's uptime. Add a ServiceRegisterEvent/ServiceUnregisterEvent listener that keeps the registered Vault integration in sync with whatever Economy provider Vault currently has, instead of relying on a single lookup at boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.