Tabs are out of order - #927
Merged
sfisher merged 2 commits intoSep 3, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #918 .
This required restructuring of the page and using new "fake" bootstrap styles since the previous version was out of order and there was no easy way to set tabindexes correctly with the different portions of the page and how it changes.
It was already redone for the "Create" pages, but made the same changes to the "demo" pages.
There are still some problems on these pages which is choosing different identifier types reloads the page and doesn't go back to the same place. That'll be the next change which I'll probably base off this PR since that'll be the new version of the page.
May want to wait to review until I get that done since you can look at both at once.