Demonstration of migration to Dotnet v6.0 - #7
Open
kaytak wants to merge 7 commits into
Open
Conversation
Owner
|
@kaytak thanks. Actually, I have a project where I've upgraded the whole DWSIM package to .NET 6, it is just not open source yet, but I will do it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Daniel,
First of all, thank you for your great work for chemical engineering community.
In this pull request, I would like to give you an overview and impression how easy your code could be migrated from dotnet framework v4.x to dotnet v6.0/later.
You don't need to merge this PR and just clone my fork in kaytak:DTL.Core:master if you just want to overview it.
As you may know, dotnet ecosystem has been drastically changed after dotnet Core was released, and there were some pain if we migrate from dotnet framework to dotnet core. However, now dotnet v6.0 has been released and the migration is no longer big deal at all since almost all source code could work with minor modifications. One of the biggest advantage of dotnet v6+ is its performance, in general dotnet v6 app has more than 50% of performance improvement than the one made with dotnet framework v4.x.
In this PR, some dependency library are removed or replaced with dummy routine, since their source codes are not available, however, such dependency could be also included once they are complied on dotnet v6.0.
I hope this PR will give you an insight to future improvement of DWSIM.
Best regards,