Update ci.yml#216
Conversation
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
There was a problem hiding this comment.
Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Deployment failed with the following error: Learn More: https://vercel.com/dargon789-forge?upgradeToPro=build-rate-limit |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Code Review
This pull request updates the Rust Docker image version in the CircleCI configuration from 1.88.0 to 1.89.0. Feedback suggests using the 1.89 tag instead of 1.89.0 to align with the toolchain and prevent unnecessary runtime downloads. Additionally, the reviewer identified redundant steps within the job and noted that the job should be renamed to build to ensure proper execution by CircleCI in the absence of a workflows section.
| build-and-test: | ||
| docker: | ||
| - image: cimg/rust:1.88.0 | ||
| - image: cimg/rust:1.89.0 |
There was a problem hiding this comment.
The rust-toolchain.toml file specifies the Rust channel as 1.89. Pinning the Docker image to 1.89.0 may cause rustup to download a newer patch version at runtime if one is available, increasing build time. Consider using the 1.89 tag to stay in sync with the toolchain.
Additionally, the 'Check formatting' and 'Run tests' steps are redundantly duplicated in this job (lines 13-18 and 27-32) and should be removed to improve CI efficiency. Also, note that without a workflows section, CircleCI expects a job named build rather than build-and-test to execute the pipeline.
- image: cimg/rust:1.89
No description provided.