Create mdbook.yml - #28
Conversation
…2738) (#5) * ci(bench): add Wall Clock Time metric to results table (paradigmxyz#22738) Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> * fix: skip persisted peers without a confirmed fork ID on startup (paradigmxyz#22734) * fix(grafana): use correct metric for block buffer blocks panel (paradigmxyz#22741) Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com> * feat(metrics): add /debug/tokio/dump endpoint for tokio task dumps (paradigmxyz#22737) Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> * perf(net): increase default concurrent outbound dials to 30 (paradigmxyz#22744) Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> Co-authored-by: Emma Jamieson-Hoare <emmajam@users.noreply.github.com> Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Amp <amp@ampcode.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 7 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v7...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the cargo-weekly group with 5 updates: | Package | From | To | | --- | --- | --- | | [alloy-eip7928](https://github.com/alloy-rs/eips) | `0.3.2` | `0.3.3` | | [moka](https://github.com/moka-rs/moka) | `0.12.13` | `0.12.14` | | [sysinfo](https://github.com/GuillaumeGomez/sysinfo) | `0.38.2` | `0.38.3` | | [tracing-logfmt](https://github.com/EmbarkStudios/tracing-logfmt) | `0.3.5` | `0.3.7` | | [ipnet](https://github.com/krisprice/ipnet) | `2.11.0` | `2.12.0` | Updates `alloy-eip7928` from 0.3.2 to 0.3.3 - [Changelog](https://github.com/alloy-rs/eips/blob/main/CHANGELOG.md) - [Commits](alloy-rs/eips@alloy-eip7928-v0.3.2...alloy-eip7928-v0.3.3) Updates `moka` from 0.12.13 to 0.12.14 - [Release notes](https://github.com/moka-rs/moka/releases) - [Changelog](https://github.com/moka-rs/moka/blob/main/CHANGELOG.md) - [Commits](moka-rs/moka@v0.12.13...v0.12.14) Updates `sysinfo` from 0.38.2 to 0.38.3 - [Changelog](https://github.com/GuillaumeGomez/sysinfo/blob/main/CHANGELOG.md) - [Commits](GuillaumeGomez/sysinfo@v0.38.2...v0.38.3) Updates `tracing-logfmt` from 0.3.5 to 0.3.7 - [Release notes](https://github.com/EmbarkStudios/tracing-logfmt/releases) - [Changelog](https://github.com/EmbarkStudios/tracing-logfmt/blob/main/CHANGELOG.md) - [Commits](EmbarkStudios/tracing-logfmt@0.3.5...0.3.7) Updates `ipnet` from 2.11.0 to 2.12.0 - [Release notes](https://github.com/krisprice/ipnet/releases) - [Changelog](https://github.com/krisprice/ipnet/blob/master/RELEASES.md) - [Commits](krisprice/ipnet@2.11.0...2.12.0) --- updated-dependencies: - dependency-name: alloy-eip7928 dependency-version: 0.3.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-weekly - dependency-name: moka dependency-version: 0.12.14 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-weekly - dependency-name: sysinfo dependency-version: 0.38.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-weekly - dependency-name: tracing-logfmt dependency-version: 0.3.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-weekly - dependency-name: ipnet dependency-version: 2.12.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-weekly ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
* Update issue templates * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6 to 7. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v6...v7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3 to 4. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v3...v4) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/bake-action](https://github.com/docker/bake-action) from 6 to 7. - [Release notes](https://github.com/docker/bake-action/releases) - [Commits](docker/bake-action@v6...v7) --- updated-dependencies: - dependency-name: docker/bake-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [quinn-proto](https://github.com/quinn-rs/quinn) from 0.11.13 to 0.11.14. - [Release notes](https://github.com/quinn-rs/quinn/releases) - [Commits](quinn-rs/quinn@quinn-proto-0.11.13...quinn-proto-0.11.14) --- updated-dependencies: - dependency-name: quinn-proto dependency-version: 0.11.14 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 3 to 4. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v3...v4) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lz4_flex](https://github.com/pseitz/lz4_flex) from 0.12.0 to 0.12.1. - [Release notes](https://github.com/pseitz/lz4_flex/releases) - [Changelog](https://github.com/PSeitz/lz4_flex/blob/main/CHANGELOG.md) - [Commits](PSeitz/lz4_flex@0.12.0...0.12.1) --- updated-dependencies: - dependency-name: lz4_flex dependency-version: 0.12.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.22 to 0.3.23. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](tokio-rs/tracing@tracing-subscriber-0.3.22...tracing-subscriber-0.3.23) --- updated-dependencies: - dependency-name: tracing-subscriber dependency-version: 0.3.23 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Reviewer's GuideAdds a new GitHub Actions workflow to build an mdBook project and deploy it to GitHub Pages on pushes to main or manual dispatch. Flow diagram for mdBook GitHub Actions workflow jobs and stepsflowchart TD
A[Trigger
push to main
or workflow_dispatch]
B[Job build
runs-on ubuntu-latest]
C[Step
actions/checkout@v4]
D[Step
Install mdBook
- install rustup
- rustup update
- cargo install mdbook 0.4.36]
E[Step
actions/configure-pages@v5
id pages]
F[Step
mdbook build]
G[Step
actions/upload-pages-artifact@v3
path ./book]
H[Job deploy
environment github-pages
needs build]
I[Step
actions/deploy-pages@v5
id deployment]
A --> B
B --> C --> D --> E --> F --> G --> H --> I
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The rustup installation command looks incorrect (
-yis currently being passed to curl instead of the install script); consider using the standard formcurl ... | sh -s -- -yso the installer runs non-interactively as intended. - Installing a full Rust toolchain on every run just to get
mdbookis quite heavy; you may want to switch to downloading a prebuilt mdBook binary or using a reusable action to reduce build time and complexity.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The rustup installation command looks incorrect (`-y` is currently being passed to curl instead of the install script); consider using the standard form `curl ... | sh -s -- -y` so the installer runs non-interactively as intended.
- Installing a full Rust toolchain on every run just to get `mdbook` is quite heavy; you may want to switch to downloading a prebuilt mdBook binary or using a reusable action to reduce build time and complexity.
## Individual Comments
### Comment 1
<location path=".github/workflows/mdbook.yml" line_range="35-39" />
<code_context>
+ - name: Install mdBook
+ run: |
+ curl --proto '=https' --tlsv1.2 https://sh.rustup.rs -sSf -y | sh
+ rustup update
+ cargo install --version ${MDBOOK_VERSION} mdbook
+ - name: Setup Pages
</code_context>
<issue_to_address>
**suggestion (performance):** Running `rustup update` immediately after a fresh install is redundant and slows the workflow.
After installing via the bootstrap script, the toolchain is already up to date, so running `rustup update` each time only adds network and build time. Consider removing it or switching to a more targeted install that fetches only the required toolchain.
```suggestion
- name: Install mdBook
run: |
curl --proto '=https' --tlsv1.2 https://sh.rustup.rs -sSf -y | sh
cargo install --version ${MDBOOK_VERSION} mdbook
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - name: Install mdBook | ||
| run: | | ||
| curl --proto '=https' --tlsv1.2 https://sh.rustup.rs -sSf -y | sh | ||
| rustup update | ||
| cargo install --version ${MDBOOK_VERSION} mdbook |
There was a problem hiding this comment.
suggestion (performance): Running rustup update immediately after a fresh install is redundant and slows the workflow.
After installing via the bootstrap script, the toolchain is already up to date, so running rustup update each time only adds network and build time. Consider removing it or switching to a more targeted install that fetches only the required toolchain.
| - name: Install mdBook | |
| run: | | |
| curl --proto '=https' --tlsv1.2 https://sh.rustup.rs -sSf -y | sh | |
| rustup update | |
| cargo install --version ${MDBOOK_VERSION} mdbook | |
| - name: Install mdBook | |
| run: | | |
| curl --proto '=https' --tlsv1.2 https://sh.rustup.rs -sSf -y | sh | |
| cargo install --version ${MDBOOK_VERSION} mdbook |
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
Summary by Sourcery
Add a GitHub Actions workflow to build and deploy the mdBook site to GitHub Pages on pushes to the main branch.
CI:
Deployment: