Skip to content

Make it work :) - #20

Open
Minishlink wants to merge 5 commits into
DrewML:masterfrom
Minishlink:make-it-work
Open

Make it work :)#20
Minishlink wants to merge 5 commits into
DrewML:masterfrom
Minishlink:make-it-work

Conversation

@Minishlink

Copy link
Copy Markdown

Hi,

The extension is not working anymore as-is. I put some fixes here.

@Minishlink

Copy link
Copy Markdown
Author

Here's a build for those interested: https://github.com/Minishlink/GifHub/releases/tag/v1.0.9

Comment thread src/js/sites/GitHub/api.js Outdated
downsizedUri: imgs.get(1).src
};
});
const $res = $(res);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind fixing the indentation here to 4 spaces to match the rest of the file? 😃

@DrewML

DrewML commented Feb 3, 2017

Copy link
Copy Markdown
Owner

Thanks for doing this! I haven't used the extension in awhile, so I didn't notice! Happy to merge/release once you fix the super tiny nit I left about spacing.

"background": {
"scripts": ["background.js"],
"peristent": false
"persistent": false

@DrewML DrewML Feb 3, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Can't believe I missed that 😆. Nice catch

@Minishlink

Copy link
Copy Markdown
Author

You're very welcome, thanks for the extension!

@tobiasbueschel

Copy link
Copy Markdown

Thanks for the great extension @DrewML 👍 it would be great to get this PR merged and update the version of the extension on the Chrome store as it is currently not working anymore.

@Starefossen

Copy link
Copy Markdown

Are there anything we can do to help getting this PR merged?

@tiagojdf

Copy link
Copy Markdown

@Minishlink @DrewML awesome work. Could you merge and update the version on the extension store?

@amis47

amis47 commented Nov 13, 2017

Copy link
Copy Markdown

merge + 1

@Braunson

Copy link
Copy Markdown

@DrewML Any possibility of merging this?

@javiergarciagonzalez

Copy link
Copy Markdown

Yeah, merge this! :)

@VincentCATILLON

Copy link
Copy Markdown

Another ping after 1 yr and a half of waiting your merge lol 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants