Skip to content

Fix broken CI status badge in repo readme#84

Closed
janbrasna wants to merge 1 commit into
minimistjs:mainfrom
janbrasna:ci-status-badge
Closed

Fix broken CI status badge in repo readme#84
janbrasna wants to merge 1 commit into
minimistjs:mainfrom
janbrasna:ci-status-badge

Conversation

@janbrasna

Copy link
Copy Markdown

The service to provide the payload for the status badge seems no longer available.
badge

Shields provide some default endpoints, from which a good one to pull "all green" on main for all the workflows at once seems to be /check-runs/ without either picking a single workflow to emit directly via GHA endpoints, or going some bespoke way. This looks it suits the task well.

👓 Preview: 325aa4a

@shadowspawn

Copy link
Copy Markdown
Member

Thanks for looking into it, and a link to a preview.

Looks reasonable to me.

Docs: https://shields.io/badges/git-hub-tag-check-runs

@shadowspawn shadowspawn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this actually works, then awesome, I'll use it everywhere.

@janbrasna janbrasna closed this Dec 30, 2025
@janbrasna janbrasna deleted the ci-status-badge branch December 30, 2025 22:31
@shadowspawn

Copy link
Copy Markdown
Member

We hadn't merged this yet @janbrasna , did you perhaps close the PR by mistake, or have you discovered a problem with the change?

(Easy change for us to make manually so no problem from that point of view.)

@janbrasna

Copy link
Copy Markdown
Author

The change was committed via ecfdaea — thus conflicting with this PR, which is therefore no longer necessary.

@shadowspawn

Copy link
Copy Markdown
Member

Oh, I missed that. Thanks again for the research and suggestion.

@ljharb

ljharb commented Dec 31, 2025

Copy link
Copy Markdown
Member

yup, sorry for not closing this PR when i pushed that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants