ci: run checks on pushes to main and PRs into any branch - #622
Merged
Conversation
Two gaps let commits through unchecked: - The workflow was `pull_request`-only, so no commit landing on main has ever been checked (0 push-event runs across its whole history). Adding a push trigger for main also covers the case where a PR is conflicted: GitHub cannot build a merge commit for it, so no `pull_request` run is queued at all and the PR silently reports no checks. - The `branches: [main]` filter meant PRs targeting long-lived branches such as partykit were never checked. Dropping the filter covers them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4yz32eN68JEB6aHmhBX7V
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps let commits through unchecked:
The workflow was
pull_request-only, so no commit landing on main hasever been checked (0 push-event runs across its whole history). Adding
a push trigger for main also covers the case where a PR is conflicted:
GitHub cannot build a merge commit for it, so no
pull_requestrun isqueued at all and the PR silently reports no checks.
The
branches: [main]filter meant PRs targeting long-lived branchessuch as partykit were never checked. Dropping the filter covers them.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01W4yz32eN68JEB6aHmhBX7V