Skip to content

metal: assert on texture_generate_mipmaps for non-mipmapped textures #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-fl3 merged 1 commit into from
Jun 16, 2026
Merged

metal: assert on texture_generate_mipmaps for non-mipmapped textures #637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/graphics/metal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,13 +498,21 @@ impl RenderingBackend for MetalContext {
unimplemented!()
}
fn texture_generate_mipmaps(&mut self, texture: TextureId) {
let texture = self.textures.get(texture);
// Catch the bug at the call site instead of letting Metal
// assert on `mipmapLevelCount > 1` deep inside the blit
// encoder. Set `TextureParams::allocate_mipmaps = true` at
// creation to use this entry point.
assert!(
texture.params.allocate_mipmaps,
"texture_generate_mipmaps called on a texture allocated without mipmaps",
);
unsafe {
if self.command_buffer.is_none() {
self.command_buffer = Some(msg_send![self.command_queue, commandBuffer]);
}
let command_buffer = self.command_buffer.unwrap();
let encoder = msg_send_![command_buffer, blitCommandEncoder];
let texture = self.textures.get(texture);
msg_send_![encoder, generateMipmapsForTexture: texture.texture];
msg_send_![encoder, endEncoding];
}
Expand Down
Loading