create window with x y position - #658
Open
mcrgnt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
Conf.window_x/Conf.window_yapplied at window creation, so desktop apps can restore geometry without a visible jump after map.None(default) keeps current platform / WM placement.Motivation
set_window_positionafter the window is shown races with WM placement on X11 (and similar on other desktops). Games usually do not care; desktop clients that persist window prefs do. Create-time coordinates + WM size hints avoid that race.Platform matrix
CreateWindowExuses coords whenSome, elseCW_USEDEFAULTXCreateWindow+USPosition/PPositionhints whenSomesetFrameTopLeftPointwhen bothSome, elsecenterAPI
Screen coordinates, top-left origin (same convention as
set_window_position).Notes
Option<(u32, u32)>.