Fix nested --github-output group for progress report nested inside timeline - #1658
Merged
Merged
Conversation
koct9i
marked this pull request as ready for review
May 3, 2026 09:30
koct9i
force-pushed
the
fix-nested-github-output-group
branch
2 times, most recently
from
May 18, 2026 10:22
0511f0c to
e998694
Compare
Contributor
Author
|
Funny enough my project still use 2.26.x, so I haven't seen that this feature is broken again since 2.27.x =) |
…meline Do not emit group when progress report is nested in timeline or failure. Unfortunately github logging does not handle nested groups correctly. Commit 606c1cb passed "isVeryVerbose" as to argument "emitGroup", while should pass to "emitGinkgoWriterOutput". So, it break fix added in commit fdc65b1. Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
koct9i
force-pushed
the
fix-nested-github-output-group
branch
from
May 18, 2026 10:26
e998694 to
59fdebb
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not emit group when progress report is nested in timeline or failure.
Unfortunately github logging does not handle nested groups correctly.
Commit 606c1cb passed "isVeryVerbose" as
to argument "emitGroup", while should pass to "emitGinkgoWriterOutput".
So, it break fix added in commit fdc65b1.