Repository navigation
✨ more accurate root cause, dashboard improvements - #617
Merged
Merged
Conversation
The scenario library has no production code and does not use -coverpkg, so covering it added no coverage but cost most of the Verify job. Coverage now runs over every other package, and the scenarios run under -race with the alert-quality gates in a separate Scenarios job beside Verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More accurate root cause, clearer evidence, and dashboard improvements.
Root cause and detection
restartPolicyRules,RestartAllContainers, native sidecars, shortcrashLoopBackOff.maxContainerRestartPeriod) are no longer read as crashes; messages name a failing sidecar or init container.failed, or pending/uninstalling for 15 min, via a metadata-only watch of release Secrets (no new permission). Notify level, never paged; steps includehelm rollback.rollout undosuggestion as Deployments.Evidence and messages
app.gitOpsLinks), commit fromorg.opencontainers.image.source/.revisionannotations, and image.evidence.checked).Self-health and dashboard
heartbeatalways shown in/healthand/api/status.app.disableSelfAlertsturns it off).Providers and chart
alert.servicenow), one incident per kwatch incident via the Table API, found again bycorrelation_id.priorityClassin the Helm chart (priorityClass.create).Tests and docs