[IMP] Add Most Recently Used Option to M20 Field. by zakiuu · Pull Request #4 · acsone/web

zakiuu · 2016-09-14T16:28:19Z

No description provided.

[ADD] support 'no_open_edit' on many2one [FIX] typos

Adapt JS file to the new JS API and make the module installable [MIG] adapt form.js to the new API. [FIX] Fix bug mentioned in pull OCA#262. [MIG] Make the module installable.

Make the module installable and update the module version [MIG] Make the module installable and update the version [FIX] Add the render_value function for the FieldMany2ManyTags and change selector from oe_tag to badge [FIX] change selector in the base.xml from span.oe_tag to span.badge

…n the many2many tag widget

…is set or not and improve search_more condition statement

…nstead of the doing it in the render_value

sbidoul · 2016-09-14T16:32:53Z

+                            queue.push(self.get_value(true));
+                        }
+                        restore_mru_list[key] = queue;
+                    }


if it's already in the queue, then it should be removed and reinserted on top?

Nope it will stay in place, you referring that the most recurrent one
should be on top?
On Wed, Sep 14, 2016 at 5:32 PM Stéphane Bidoul (ACSONE) <
notifications@github.com> wrote:

In web_m2x_options/static/src/js/form.js
#4 (comment):

var key = self.compute_mru_key();

// check if the localstorage has some items for the current model

if (localStorage.getItem(mru_option)) {

var restore_mru_list = JSON.parse(localStorage.getItem(mru_option));

if (restore_mru_list[key]) {

var queue = restore_mru_list[key];

if (queue.indexOf(self.get_value(true)) < 0 && self.get_value(true)){

if (queue.length < 5) {

queue.push(self.get_value(true));

}else {

queue.shift();

queue.push(self.get_value(true));

}

restore_mru_list[key] = queue;

}

if it's already in the queue, then it should be removed and reinserted on
top?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/acsone/web/pull/4/files/1ab5431bcf13c489922e34a1ea8c6f97bb38dcfc#r78785062,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANkfciG82hE6aWYUnO1n8ooTvYdF_ehks5qqCG1gaJpZM4J8-Ur
.

he most recurrent one should be on top

Yes, otherwise your most frequently used one will drop off the list, ex with a size of 3

A -> [ A ]

B -> [ B, A ]

A -> [ B, A ]

C -> [ C, B, A ]

A -> [ C, B, A ]

D -> [ D, C, B ] and you've lost A even though you use it often

Yeah I,ll do

On Wed, Sep 14, 2016 at 5:45 PM Stéphane Bidoul (ACSONE) <
notifications@github.com> wrote:

In web_m2x_options/static/src/js/form.js
#4 (comment):

var key = self.compute_mru_key();

// check if the localstorage has some items for the current model

if (localStorage.getItem(mru_option)) {

var restore_mru_list = JSON.parse(localStorage.getItem(mru_option));

if (restore_mru_list[key]) {

var queue = restore_mru_list[key];

if (queue.indexOf(self.get_value(true)) < 0 && self.get_value(true)){

if (queue.length < 5) {

queue.push(self.get_value(true));

}else {

queue.shift();

queue.push(self.get_value(true));

}

restore_mru_list[key] = queue;

}

he most recurrent one should be on top

Yes, otherwise your most frequently used one will drop off the list, ex
with a size of 3

A -> [ A ]

B -> [ B, A ]

A -> [ B, A ]

C -> [ C, B, A ]

A -> [ C, B, A ]

D -> [ D, C, B ] and you've lost A even though you use it often

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/acsone/web/pull/4/files/1ab5431bcf13c489922e34a1ea8c6f97bb38dcfc#r78787414,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANkfdW_F88NTUYXC1ydsTvvmUZ56MNXks5qqCSXgaJpZM4J8-Ur
.

…edit options aren't set

…edit options aren't set.

sbidoul

Don't worry with translations, they will be managed with transifex when merged. Touch this now generates merge conflicts.

sbidoul · 2016-09-17T16:28:15Z

@zakiuu This looks suspicious.

sbidoul · 2016-09-17T16:38:12Z

@zakiuu when web_m2x_options is installed, the style of the "create and edit..." changes. This is suspicious too, can you look into it? I've not tested on community, I hope it's possible to have a solution that works both on community and enterprise.

When not installed:

When installed:

sbidoul · 2016-09-17T16:55:46Z

I've had this stack trace while doing this.

open a supplier invoice, click edit then
In the supplier popup, clieck on the account drop down

And also this in the console

zakiuu · 2016-09-18T08:50:05Z

@sbidoul for the "create and edit...", unfortunately, there is a difference in the CSS class between the enterprise and community edition (o_m2o_dropdown_option,oe_m2o_dropdown_option respectively).

sbidoul · 2016-09-19T06:44:33Z

@zakiuu would it work if you put both classes (o and oe)?

zakiuu · 2016-09-19T07:41:49Z

Yeah it does work, but shouldn't we add something specific to enterprise
edition in a community module?

On Mon, Sep 19, 2016 at 7:44 AM Stéphane Bidoul (ACSONE) <
notifications@github.com> wrote:

@zakiuu https://github.com/zakiuu would it work if you put both classes
(o and oe)?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AANkfah4YzVe7zQDMOHO_KT2gX3jKemuks5qri9RgaJpZM4J8-Ur
.

sbidoul · 2016-09-19T07:45:47Z

Using both oe and o classes is not shocking to me. Odoo always sais the web api must be compatible for community and enterprise, so if using both classes it what it takes to have that compatibility, that's fine with me.

Also the oe_ classes seem to be gone in v10 so it's just anticipating a bit.

zakiuu · 2016-09-19T07:46:55Z

Ok sounds good to me

On Mon, Sep 19, 2016 at 8:45 AM Stéphane Bidoul (ACSONE) <
notifications@github.com> wrote:

Using both oe and o classes is not shocking to me. Odoo always sais the
web api must be compatible for community and enterprise, so if using both
classes it what it takes to have that compatibility, that's fine with me.

Also the oe_ classes seem to be gone in v10 so it's just anticipating a
bit.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AANkfS2J4poWElqustXH8kjwcrokccwmks5qrj2rgaJpZM4J8-Ur
.

display most recently used record to the user when the search_mru is true. [IMP] add compute_mru_key to compute the key of the field in the local storage in the form: dbname/model/view_id | action_id/field_name [IMP] add get_search_mru to search if there is a list of values stored in the local storage using the key generate. [IMP] add update_mru_list to update they list of mru saved in local storage [IMP] Add mru behavior to the get_search_value [IMP] add web_m2x_options.search_mru option to the OPTIONS list

… item in the top of the list and add some important comments

lmignon · 2016-11-09T13:01:18Z

superseded by #6

[FIX] web_shortcut: QWeb render doesn't use string keys

hbrunn and others added 26 commits September 9, 2016 16:30

support 'open' on many2many_tags

0831ddc

[ADD] support 'no_open_edit' on many2one [FIX] typos

adapt README.rst to OCA template

2986129

@pedrobaeza's proposals to roadmap

aeb69ac

missing word in readme

b06a541

this week's pylint errors

a030ab4

web_m2x_options check Many2one and Many2many options

7c39fe4

Fix many2many JS error

4bd1e86

OCA Transbot updated translations from Transifex

08bbc42

OCA Transbot updated translations from Transifex

33a3b44

OCA Transbot updated translations from Transifex

d5eef66

OCA Transbot updated translations from Transifex

e6aad8e

OCA Transbot updated translations from Transifex

3be8ab1

Limit name_search to 160 like Odoo core does

ab6502a

OCA Transbot updated translations from Transifex

9d5e776

OCA Transbot updated translations from Transifex

4732585

OCA Transbot updated translations from Transifex

d89cd06

OCA Transbot updated translations from Transifex

4fc2c3a

OCA Transbot updated translations from Transifex

aa58a0e

Normalize version number

fa45965

remove en.po that was erroneously created by transbot

b4b64fd

[9.0][MIG] Migration of module web_m2x_options.

7115953

Adapt JS file to the new JS API and make the module installable [MIG] adapt form.js to the new API. [FIX] Fix bug mentioned in pull OCA#262. [MIG] Make the module installable.

[FIX] Add $ variable and replace jquery staments by $

8cf6b2e

add is_option_set function to check whether an option is set or not i…

cbd8d73

…n the many2many tag widget

[IMP] Make sure to use is_option_set everytime we check if an option …

0006450

…is set or not and improve search_more condition statement

[FIX] Override the .badge click event to open the clicked ressource i…

5d8de13

…nstead of the doing it in the render_value

sbidoul reviewed Sep 14, 2016
View reviewed changes

[FIX] Fix condition when options tag is defined but create or create_…

9079e0d

…edit options aren't set

zakiuu force-pushed the 9.0-web_m2x_options-mru-zak branch from d26a86e to e586cd8 Compare September 15, 2016 10:21

[FIX] Fix condition when options tag is defined but create or create_…

c90b8fe

…edit options aren't set.

zakiuu force-pushed the 9.0-web_m2x_options-mru-zak branch from e586cd8 to b65e90d Compare September 15, 2016 13:14

[FIX] Fix line numbers in the .po files

ec53572

sbidoul reviewed Sep 17, 2016

View reviewed changes

[FIX] add require('_')

07589f7

zakmak88 and others added 10 commits September 19, 2016 09:17

[IMP] Add classname compatiblity to odoo versions

7f9bbea

[IMP] Update the readme file the new option added

0ebe462

[REF] Refactore the update_mru_list method to always put the selected…

95f1b18

… item in the top of the list and add some important comments

[FIX] Add codeview button to translate HTML fields

3032236

[REF] Refactore compute_mru_key

28fb5b8

[FIX] Revert changes on .po files

bb37283

[FIX] Remove unused session variable and fix bug

9f41010

[FIX] Fix bug in line 148

c46818b

[REF] remove debuging statement in line 108

d40f3bc

zakiuu force-pushed the 9.0-web_m2x_options-mru-zak branch from 03ce849 to d40f3bc Compare September 19, 2016 08:29

lmignon force-pushed the 9.0-mig2-web_m2x_options-zak branch 2 times, most recently from a9128a6 to b2303e5 Compare October 27, 2016 20:19

lmignon force-pushed the 9.0-mig2-web_m2x_options-zak branch 2 times, most recently from 2ca4915 to 0789d8f Compare November 4, 2016 09:08

lmignon closed this Nov 9, 2016

ThomasBinsfeld pushed a commit that referenced this pull request Mar 16, 2017

Merge pull request #4 from acsone/10.0-web_shortcut_fix_qweb_render_tbi

4b97c6e

[FIX] web_shortcut: QWeb render doesn't use string keys

Uh oh!

Conversation

zakiuu commented Sep 14, 2016

Uh oh!

sbidoul Sep 14, 2016

Choose a reason for hiding this comment

Uh oh!

zakiuu Sep 14, 2016

Choose a reason for hiding this comment

Uh oh!

sbidoul Sep 14, 2016

Choose a reason for hiding this comment

Uh oh!

zakiuu Sep 14, 2016

Choose a reason for hiding this comment

Uh oh!

sbidoul left a comment

Choose a reason for hiding this comment

Uh oh!

sbidoul commented Sep 17, 2016

Uh oh!

sbidoul commented Sep 17, 2016

Uh oh!

sbidoul commented Sep 17, 2016

Uh oh!

zakiuu commented Sep 18, 2016

Uh oh!

sbidoul commented Sep 19, 2016

Uh oh!

zakiuu commented Sep 19, 2016

Uh oh!

sbidoul commented Sep 19, 2016

Uh oh!

zakiuu commented Sep 19, 2016

Uh oh!

lmignon commented Nov 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants