feat(inkless): enable AZ parsing for generated client IDs [KC-330] - #699
Open
EelisK wants to merge 1 commit into
Open
feat(inkless): enable AZ parsing for generated client IDs [KC-330]#699EelisK wants to merge 1 commit into
EelisK wants to merge 1 commit into
Conversation
ClientAZExtractor determines a preferred availability zone (AZ) when the client ID explicitly embeds one. In case of Kafka Connect, the client ID is automatically generated for the worker's internal producers, consumers, and admin clients: the base client ID is concatenated with "-configs", "-offsets", "-statuses", or a UUID. Prior to this commit, these concatenated strings were incorrectly treated as the availability zones. Now if we find an AZ in the client ID, we try to match it against the configured racks/AZs and only return it if a match is found.
EelisK
marked this pull request as ready for review
July 15, 2026 14:50
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves client AZ extraction when client IDs include generated Kafka Connect suffixes (e.g., -configs, -offsets, UUIDs), by validating extracted diskless_az values against known rack/AZ identifiers and stripping suffixes until a known rack match is found.
Changes:
- Extend
ClientAZExtractorto optionally validate an extracted AZ against known racks and progressively strip-...suffixes to find the longest matching rack prefix. - Update
InklessTopicMetadataTransformerto pass a known-racks supplier intoClientAZExtractorduring client AZ resolution. - Add parameterized tests covering Kafka Connect-style suffixes, UUID suffixes, and validation/no-validation behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| storage/inkless/src/main/java/io/aiven/inkless/metadata/ClientAZExtractor.java | Adds rack-aware validation and suffix-stripping logic for diskless_az extraction. |
| storage/inkless/src/main/java/io/aiven/inkless/metadata/InklessTopicMetadataTransformer.java | Uses rack validation during client AZ resolution by supplying known racks derived from config/listener and broker metadata. |
| storage/inkless/src/test/java/io/aiven/inkless/metadata/ClientAZExtractorTest.java | Expands test coverage for suffix handling and rack validation behavior. |
Comment on lines
425
to
428
| private String resolveClientAZ(final ListenerName listenerName, final String clientId) { | ||
| final String explicitAZ = normalizeAZ(ClientAZExtractor.getClientAZ(clientId)); | ||
| final String explicitAZ = normalizeAZ( | ||
| ClientAZExtractor.getClientAZ(clientId, () -> computeKnownRacks(listenerName))); | ||
| if (explicitAZ != null) { |
Member
Author
There was a problem hiding this comment.
The AZ resolution is not unconditional. We use a supplier to only resolve them when the provided client.id specifies an AZ. I don't think it's worth trying to further optimize this.
giuseppelillo
approved these changes
Aug 7, 2026
giuseppelillo
left a comment
Contributor
There was a problem hiding this comment.
LGTM, the copilot comment seems valid tho
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientAZExtractor determines a preferred availability zone (AZ) when the client ID explicitly embeds one. In case of Kafka Connect, the client ID is automatically generated for the worker's internal producers, consumers, and admin clients: the base client ID is concatenated with "-configs", "-offsets", "-statuses", or a UUID.
Prior to this commit, these concatenated strings were incorrectly treated as the availability zones. Now if we find an AZ in the client ID, we try to match it against the configured racks/AZs and only return it if a match is found.