inkless: add last-successful-operation age gauges [KC-316] - #735
Merged
Conversation
Commit 9389b7a fixed a stuck write-path thread caused by a connection to a deleted PG node. The issue was only surfaced by the customer — no internal metric revealed the hang. Add age-of-last-success gauges so a stuck operation becomes visible before a customer reports it: - FileCommitter.LastSuccessfulFileCommitAgeMs: milliseconds since the last file commit completed successfully. - PostgresControlPlane.{QueryName}LastSuccessfulQueryAgeMs: same pattern, one gauge per query type (CommitFile, FindBatches, etc.). Both gauges return -1 before the first success, making "never ran" distinguishable from "ran very recently". Also fix missing removal of RepairDisklessLog QueryMetrics alongside all other query metrics removals. [KC-316]
jclarysse
marked this pull request as draft
August 10, 2026 10:23
jclarysse
marked this pull request as ready for review
August 10, 2026 11:16
jeqo
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 9389b7a fixed a stuck write-path thread caused by a connection to a deleted PG node. The issue was only surfaced by the customer — no internal metric revealed the hang.
Add age-of-last-success gauges so a stuck operation becomes visible before a customer reports it:
FileCommitter.LastSuccessfulFileCommitAgeMs: milliseconds since the last file commit completed successfully.
PostgresControlPlane.{QueryName}LastSuccessfulQueryAgeMs: same pattern, one gauge per query type (CommitFile, FindBatches, etc.).
Both gauges return -1 before the first success, making "never ran" distinguishable from "ran very recently".
Also fix missing removal of RepairDisklessLog QueryMetrics alongside all other query metrics removals.
KC-316