Tags: ajpalkovic/flow
Tags
[hack] fix File_url slashes on Windows Summary: Pull Request resolved: facebook#8142 previously, `File_url.parse "file:///c%3A/foo/bar"` returned `"c:/foo/bar"` instead of `"c:\foo\bar"`, because `/` and `\` are (generally) interchangeable on Windows. however, `Sys_utils.realpath` does convert them to `\` (only if the file exists, otherwise it leaves it alone!), which makes it more difficult to compare two paths. so, we now match `realpath`'s behavior, converting `/` to `\` on Windows. also, `File_url.create "c:\foo\bar"` returns `"file:///c%3A/foo/bar"` on Windows, but on Linux, `\` is a valid path character and should be escaped, like `"file:///c%3A%5Cfoo%5Cbar"`. Reviewed By: gabelevi, samwgoldman Differential Revision: D18024985 fbshipit-source-id: 2f09b7f3587a0b01a3ee9ab935ed67cc0d308164
Fix source of flakiness for lsp/completion test
Summary:
I noticed that {D17584973} failed this test. I think it was a source of flakiness. Most of the test cases look like
1. Add `jsx.js` (which has syntax errors)
2. Start the lsp server and server
3. Send a completion request
4. Assert the response matches.
When the lsp starts up, it will see the syntax errors and send the `textDocument/publishDiagnostics` message to the client. Usually this happens between steps 2 and 3. But if it happens after 3 then the step 4 assertion would fail like this:
```
+ textDocument/publishDiagnostics,textDocument/completion{"isIncomplete":false,"items":[{"label":"a","kind":6,"detail":"number","inlineDetail":"number","insertTextFormat":1}]}
- textDocument/completion{"isIncomplete":false,"items":[{"label":"a","kind":6,"detail":"number","inlineDetail":"number","insertTextFormat":1}]}
```
(Full logs: P113545680)
Easy fix. Just ignore those messages
Reviewed By: nmote
Differential Revision: D17602294
fbshipit-source-id: 7c6f2a7ae84f5d3caffae90fdaacc0e57ea46775
PreviousNext