Improve main file security - #2
Open
altyni86 wants to merge 2 commits into
Open
Conversation
Co-authored-by: altyni <altyni@gmail.com>
|
Cursor Agent can help with this pull request. Just |
altyni86
marked this pull request as ready for review
December 6, 2025 23:26
Co-authored-by: altyni <altyni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden
BatchInvokercontract with explicit signature validation and a balance-invariant guard.This improves security by rejecting replay attempts with invalid signatures and preventing forced ETH transfers from bricking the contract. The contract now ensures its balance returns to the pre-execution state, accounting for
msg.value, covering both leftover value and attempts to siphon forced deposits. The test suite has been expanded to cover these new safeguards, andfoundry.lockis now tracked for deterministic dependency resolution.Note
Add explicit signature validation and a stricter balance-invariant in
BatchInvoker, with new tests for invalid signatures and forced ETH transfers.src/BatchInvoker.sol):InvalidSignatureerror and revert whenauth(...)returnsaddress(0).startingBalance = address(this).balance - msg.valueand revertingExtraValueif final balance differs; update related docs.test/BatchInvoker.t.sol):ForceSendhelper and test to ensure forced ETH does not break executions and balance remains unchanged.ExtraValuebehavior.Written by Cursor Bugbot for commit 1fafce0. This will update automatically on new commits. Configure here.